You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by manjuapu <gi...@git.apache.org> on 2017/09/19 19:55:46 UTC
[GitHub] kafka-site pull request #79: Adding Customer section to Streams page
GitHub user manjuapu opened a pull request:
https://github.com/apache/kafka-site/pull/79
Adding Customer section to Streams page
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/manjuapu/kafka-site customer-kafka
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka-site/pull/79.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #79
----
commit 548218756753afd49c5925898a194755a37e6c11
Author: Manjula K <ma...@kafka-summit.org>
Date: 2017-09-05T21:37:53Z
Adding portoseguro, micronauticsresearch & cj logos to powered by page
commit 4afeae8c02ef34494f0852897eff24ee74fb8eaa
Author: manjuapu <ma...@confluent.io>
Date: 2017-09-06T22:20:17Z
Delete .DS_Store
commit 0e5f634fbfeb947af3dc27aedb6378073dfc3b2a
Author: Manjula K <ma...@kafka-summit.org>
Date: 2017-09-06T22:23:08Z
Formatted powered by page code
commit 78ba1960a686b69cdf23e8e28c33c8405ce8b70c
Author: Manjula K <ma...@kafka-summit.org>
Date: 2017-09-06T22:26:49Z
removed .DS_Store
commit 274bd31af7da24150d8ae37482174d622d2b982c
Author: Manjula K <ma...@kafka-summit.org>
Date: 2017-09-18T22:10:31Z
test
commit 2f50c9caf5dffc8f7e04d44fd34100fe87aef84c
Author: Manjula K <ma...@kafka-summit.org>
Date: 2017-09-19T18:59:32Z
See how Kafka Streams is being used section added
----
---
[GitHub] kafka-site pull request #79: Adding Customer section to Streams page
Posted by ewencp <gi...@git.apache.org>.
Github user ewencp commented on a diff in the pull request:
https://github.com/apache/kafka-site/pull/79#discussion_r139804782
--- Diff: css/styles.css ---
@@ -993,3 +993,76 @@ nav .btn {
margin-right: 0;
}
}
+
+.customer__cards {
+ display: flex;
+ height: 30rem;
+ max-width: 92rem;
+
+ }
+
+ .customer_cards_2{
--- End diff --
Can we fix the formatting and indentation in this file -- there's extra indents and some random +/- 1 spaces between lines.
---
[GitHub] kafka-site pull request #79: Adding Customer section to Streams page
Posted by ewencp <gi...@git.apache.org>.
Github user ewencp commented on a diff in the pull request:
https://github.com/apache/kafka-site/pull/79#discussion_r139804545
--- Diff: 0110/streams/index.html ---
@@ -202,7 +202,40 @@ <h3 style="max-width: 75rem;">The easiest way to write mission-critical real-tim
</div>
</div>
-
+ <h3 class="customer-title">See how Kafka Streams is being used</h3>
--- End diff --
The directories that correspond to version numbers are managed under the main Kafka repo under the [docs/ directory](https://github.com/apache/kafka/tree/trunk/docs) -- it's a bit annoying that the site is split up like this, but that's currently how it's managed. In order to ensure that all future versions see these changes as well, you'd create a regular Kafka PR to make the changes and then if you want it to appear immediately you'd ask for it to also be cherry picked to 0.11.0 and that the docs be redeployed (which requires a committer to build them, copy them over here, and commit).
This patch might be a little weird because the css only lives in this repo, but the rest of the patch should end up in the main Kafka repo.
---
[GitHub] kafka-site pull request #79: Adding Customer section to Streams page
Posted by manjuapu <gi...@git.apache.org>.
Github user manjuapu closed the pull request at:
https://github.com/apache/kafka-site/pull/79
---
[GitHub] kafka-site pull request #79: Adding Customer section to Streams page
Posted by ewencp <gi...@git.apache.org>.
Github user ewencp commented on a diff in the pull request:
https://github.com/apache/kafka-site/pull/79#discussion_r139804582
--- Diff: 0110/streams/index.html ---
@@ -202,7 +202,40 @@ <h3 style="max-width: 75rem;">The easiest way to write mission-critical real-tim
</div>
</div>
-
+ <h3 class="customer-title">See how Kafka Streams is being used</h3>
+ <div class="customer__cards">
+ <div class="customer__card">
+ <div class="customer__card__icon">
+ <img src="/0110/images/icons/rabobank.png">
+ </div>
+ <span class="customer__card__label">Rabobank is one of the 3 largest banks in the Netherlands. Its digital nervous system, the Business Event Bus, is powered by Apache Kafka and Kafka Streams.
+ </span>
+ <a href="https://www.confluent.io/blog/real-time-financial-alerts-rabobank-apache-kafkas-streams-api/">Learn More</a>
+ </div>
+ <div class="customer__card customer-right" >
+ <div class="customer__card__icon" >
+ <img src="/0110/images/icons/zalando.png">
+ </div>
+ <span class="customer__card__label">As the leading online fashion retailer in Europe, Zalando uses Kafka as an ESB (Enterprise Service Bus), which helps us in transitioning from a monolithic to a micro services architecture. Using Kafka for processing event streams enables our technical team to do near-real time business intelligence.</span>
+ <a href="https://kafka-summit.org/sessions/using-kstreams-ktables-calculate-real-time-domain-rankings/">Learn More</a>
+ </div>
+ </div>
+ <!--div class="customer__cards customer_cards_2">
--- End diff --
We should delete the commented stuff.
---
[GitHub] kafka-site issue #79: Adding Customer section to Streams page
Posted by guozhangwang <gi...@git.apache.org>.
Github user guozhangwang commented on the issue:
https://github.com/apache/kafka-site/pull/79
Some meta comments:
1. The `.DS_Store` should not be included.
2. As @ewencp mentioned, these files under `0110/` should be in `kafka` repo as well. You would need to file a separate PR for `kafka` repo adding these files, against trunk. The committer who merges this PR will also cherry-pick it to `0.11.0` branch. So that when 1.0.0 web docs are up these files will be reflected as well.
3. For `css/styles.css` it is only in `kafka-site` repo, so it is good as is.
---