You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Jayapal Reddy <ja...@citrix.com> on 2013/05/14 12:29:33 UTC
Review Request: Updated the ipaddress validation error msg for private gw
and update the replace network acl
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11150/
-----------------------------------------------------------
Review request for cloudstack, Abhinandan Prateek and Kishan Kavala.
Description
-------
1. Updated the error msg for the invalid private ip address parameter
2. updated the replace network acl on private gateway for configuring default cal
This addresses bug CLOUDSTACK-2400.
Diffs
-----
server/src/com/cloud/network/NetworkServiceImpl.java eeea0f2
server/src/com/cloud/network/vpc/NetworkACLServiceImpl.java ba8f489
Diff: https://reviews.apache.org/r/11150/diff/
Testing
-------
1. Tested by configuring invlida ip
2. tested by configuring replacenetworkacl for private gw with default cal
Thanks,
Jayapal Reddy
Re: Review Request: Updated the ipaddress validation error msg for private
gw and update the replace network acl
Posted by Kishan Kavala <Ki...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11150/#review20532
-----------------------------------------------------------
Ship it!
commit 46f8b6f34a2a4b6c715d4850f159ff277ef6716f
- Kishan Kavala
On May 14, 2013, 10:29 a.m., Jayapal Reddy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11150/
> -----------------------------------------------------------
>
> (Updated May 14, 2013, 10:29 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Kishan Kavala.
>
>
> Description
> -------
>
> 1. Updated the error msg for the invalid private ip address parameter
> 2. updated the replace network acl on private gateway for configuring default cal
>
>
> This addresses bug CLOUDSTACK-2400.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/NetworkServiceImpl.java eeea0f2
> server/src/com/cloud/network/vpc/NetworkACLServiceImpl.java ba8f489
>
> Diff: https://reviews.apache.org/r/11150/diff/
>
>
> Testing
> -------
>
> 1. Tested by configuring invlida ip
> 2. tested by configuring replacenetworkacl for private gw with default cal
>
>
> Thanks,
>
> Jayapal Reddy
>
>