You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2015/12/29 00:50:04 UTC
Review Request 41757: Unified Container: Added passing Env in docker
runtime config.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41757/
-----------------------------------------------------------
Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
Bugs: MESOS-4226
https://issues.apache.org/jira/browse/MESOS-4226
Repository: mesos
Description
-------
Unified Container: Added passing Env in docker runtime config.
Diffs
-----
src/slave/containerizer/mesos/provisioner/docker/store.cpp e951c96a7f9c5ff72f6993981e2e3744e3b837f6
src/slave/containerizer/mesos/provisioner/store.hpp aec725f789f7aeb92abfcc6718c2e6e2f1f37981
Diff: https://reviews.apache.org/r/41757/diff/
Testing
-------
make check (ubuntu14.04 + clang-3.6)
Thanks,
Gilbert Song
Re: Review Request 41757: Unified Container: Added passing Env in
docker runtime config.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41757/#review112370
-----------------------------------------------------------
src/slave/containerizer/mesos/provisioner/store.hpp (line 43)
<https://reviews.apache.org/r/41757/#comment172847>
Similarly, no need for Option.
- Jie Yu
On Dec. 28, 2015, 11:50 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41757/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2015, 11:50 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-4226
> https://issues.apache.org/jira/browse/MESOS-4226
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Unified Container: Added passing Env in docker runtime config.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/store.cpp e951c96a7f9c5ff72f6993981e2e3744e3b837f6
> src/slave/containerizer/mesos/provisioner/store.hpp aec725f789f7aeb92abfcc6718c2e6e2f1f37981
>
> Diff: https://reviews.apache.org/r/41757/diff/
>
>
> Testing
> -------
>
> make check (ubuntu14.04 + clang-3.6)
>
>
> Thanks,
>
> Gilbert Song
>
>