[jira] Commented: (JUDDI-426) Could disable the check for the lag time of the notification

["Kurt T Stam (JIRA)" <ju...@ws.apache.org>]

    [ https://issues.apache.org/jira/browse/JUDDI-426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925465#action_12925465 ] 

Kurt T Stam commented on JUDDI-426:
-----------------------------------

Thank you ShengTao, but what is it you are trying to achieve? jUDDI is using a Timer, sometimes the timer fires late (i.e. if the CPU is pegged). So if this happens, why should we care about an old timer event? We might as well use the current event to do our notification work. So please explain what your suggestion improves. Thx --Kurt

> Could disable the check for the lag time of the notification
> ------------------------------------------------------------
>
>                 Key: JUDDI-426
>                 URL: https://issues.apache.org/jira/browse/JUDDI-426
>             Project: jUDDI
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 3.0.1
>            Reporter: ShengTao Dong
>            Assignee: Kurt T Stam
>
> In the org.apache.juddi.subscription.SubscriptionNotifier class, there is this method:
> The value ACCEPTABLE_LAG_TIME is fixed in code and is 500ms, and could this be refactor to be a property that the user can set, and for some special value, for example '-1' will mean always notify.
>  private boolean firedOnTime(long scheduleExecutionTime) {
>         long lagTime = System.currentTimeMillis() - scheduleExecutionTime;
>         if (lagTime <= ACCEPTABLE_LAG_TIME) {
>             return true;
>         } else {
>             log.warn("NotificationTimer is lagging " + lagTime + " milli seconds behind. A lag time "
>                     + "which exceeds an acceptable lagtime of " + ACCEPTABLE_LAG_TIME + "ms indicates "
>                     + "that the registry server is under stress. We are therefore skipping this notification "
>                     + "cycle.");
>             return false;
>         }
>     }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.