You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/11/02 06:39:16 UTC
[GitHub] [iceberg] ajantha-bhat opened a new pull request, #6102: Build: Fix build version
ajantha-bhat opened a new pull request, #6102:
URL: https://github.com/apache/iceberg/pull/6102
Problems:
a. The latest master build is still `0.15.0-SNAPSHOT` instead of `1.1.0-SNAPSHOT` in the jar names.
b. [Latest Nightly snapshot publish](https://repository.apache.org/content/groups/snapshots/org/apache/iceberg/) also use `0.15.0-SNAPSHOT`
Analysis:
After debugging I found that we get the version from `gitVersion` plugin and increment [here](https://github.com/apache/iceberg/blob/master/build.gradle#L703).
But `gitVersion` plugin uses `git describe --tag` to get the reachable tag from the commit from the **master** branch.
This is the current output.
```
% git describe --tag
apache-iceberg-0.14.0-447-g70874d52a
```
**The root cause is that we created 1.0.0 tag from a side branch (not from a master branch). Hence, `git describe` cannot work.**
I tried to find alternative plugins (no luck so far) and thought of manually add code to execute commands from Gradle like
`git tag --list --sort=-version:refname "apache-iceberg-*" | head -1
`
or
`curl https://api.github.com/repos/apache/iceberg/releases/latest`
But it didn't work out as planned.
**Hence, going back to the old manual way of updating the version as a temporary fix.**
I hope to find a better solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] ajantha-bhat closed pull request #6102: Build: Fix build version
Posted by GitBox <gi...@apache.org>.
ajantha-bhat closed pull request #6102: Build: Fix build version
URL: https://github.com/apache/iceberg/pull/6102
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nastra commented on pull request #6102: Build: Fix build version
Posted by GitBox <gi...@apache.org>.
nastra commented on PR #6102:
URL: https://github.com/apache/iceberg/pull/6102#issuecomment-1310144291
@ajantha-bhat as we disussed yesterday in the Iceberg sync: Going forward we'll be tagging & releasing commits reachable from `master`, so I think this PR can be closed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nastra commented on pull request #6102: Build: Fix build version
Posted by GitBox <gi...@apache.org>.
nastra commented on PR #6102:
URL: https://github.com/apache/iceberg/pull/6102#issuecomment-1299795550
For completeness I wanted to mention that the `iceberg-build.properties` will also contain the wrong tag information (since it probably relies on the same `git describe --tag` command). Here's an example:
```
git.branch=delete-table-with-purge
git.build.version=1.1.0-SNAPSHOT
git.closest.tag.name=apache-iceberg-0.14.0
git.commit.id=90d01f60872ed3fbf15846334dd850b9dcea1d3a
git.commit.id.abbrev=90d01f6
git.commit.message.short=Core\: Pass purgeRequested flag to REST server
git.commit.time=2022-11-02T08\:09\:39+0100
git.tags=
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] ajantha-bhat commented on pull request #6102: Build: Fix build version
Posted by GitBox <gi...@apache.org>.
ajantha-bhat commented on PR #6102:
URL: https://github.com/apache/iceberg/pull/6102#issuecomment-1299800976
Also, may be rev API build maybe linked to the tag creation from master branch.
https://github.com/apache/iceberg/pull/6053
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org