[jira] [Commented] (MAPREDUCE-6652) Add configuration property to prevent JHS from loading jobs with a task count greater than X

["Ray Chiang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-6652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15261133#comment-15261133 ] 

Ray Chiang commented on MAPREDUCE-6652:
---------------------------------------

Looks pretty good to me.  A few minor nits/suggestions:

* Rename oversized() to isOversized()
* In the return value for oversized(), please add parentheses
* In HsJobBlock#render(), some cleanup and add one other actionable item for supportability:

{noformat}
html.p()._("The job has a total of " + taskCount + " tasks. ")
    ._("Any job larger than " + oversizedJob.getMaxTasksAllowed() +
    " will not be loaded.")._();
html.p()._("You can either use the command line tool: 'mapred job -history'"
    + " to view large jobs or adjust the property " +
    JHAdminConfig.MR_HS_LOADED_JOBS_TASKS_MAX + ".")._();
{noformat}

> Add configuration property to prevent JHS from loading jobs with a task count greater than X
> --------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-6652
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6652
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: jobhistoryserver
>            Reporter: Haibo Chen
>            Assignee: Haibo Chen
>         Attachments: mapreduce6652.001.patch, mapreduce6652.002.patch
>
>
> Jobs with large number of tasks can have job history files that are large in size and resource-consuming(mainly memory) to parse in Job History Server. If there are many such jobs, the job history server can very easily hang.
> It would be a good usability feature if we added a new config property that could be set to X, where the JHS wouldn't load the details for a job with more than X tasks. The job would still show up on the list of jobs page, but clicking on it would give a warning message that the job is too big, instead of actually loading the job. This way we can prevent users from loading a job that's way too big for the JHS, which currently makes the JHS hang. The default value can be -1 so that it's disabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)