You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/29 16:16:17 UTC
[GitHub] [spark] grundprinzip opened a new pull request, #38839: [SPARK-41282] [CONNECT] [PYTHON] [FOLLOWUP] Add missing functionality to column expression
grundprinzip opened a new pull request, #38839:
URL: https://github.com/apache/spark/pull/38839
### What changes were proposed in this pull request?
This patch adds lots of convenience methods to the base column expression class that are necessary for good user experience:
For example:
```
df.a & df.b
df.a.like("value")
```
### Why are the changes needed?
Compatibility
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #38839: [SPARK-41282] [CONNECT] [PYTHON] [FOLLOWUP] Add missing functionality to column expression
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #38839: [SPARK-41282] [CONNECT] [PYTHON] [FOLLOWUP] Add missing functionality to column expression
URL: https://github.com/apache/spark/pull/38839
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #38839: [SPARK-41282] [CONNECT] [PYTHON] [FOLLOWUP] Add missing functionality to column expression
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #38839:
URL: https://github.com/apache/spark/pull/38839#issuecomment-1331496537
@grundprinzip since this is adding new API, should probably better file a new JIRA, and list which API this PR proposes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #38839: [SPARK-41282] [CONNECT] [PYTHON] [FOLLOWUP] Add missing functionality to column expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #38839:
URL: https://github.com/apache/spark/pull/38839#issuecomment-1331426039
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #38839: [SPARK-41282] [CONNECT] [PYTHON] [FOLLOWUP] Add missing functionality to column expression
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #38839:
URL: https://github.com/apache/spark/pull/38839#issuecomment-1331531097
Closing this in favour of https://github.com/apache/spark/pull/38844
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org