You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/08/04 20:29:20 UTC

Review Request 24241: Add test coverage for new client API methods.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24241/
-----------------------------------------------------------

Review request for Aurora and Maxim Khutornenko.


Repository: aurora


Description
-------

Add test coverage for new client API methods.


Diffs
-----

  src/main/python/apache/aurora/client/api/scheduler_client.py 4b20efa0e8038b8fe85ecb85d842ebd89c5143d2 
  src/main/thrift/org/apache/aurora/gen/api.thrift 5c8ee52e1f4333babe153920fc6f65cdb2da2bd2 
  src/test/python/apache/aurora/client/api/test_scheduler_client.py dd16fe2afe681f81e27f1eeddd5127b322934d74 

Diff: https://reviews.apache.org/r/24241/diff/


Testing
-------

./pants src/test/python:all -vxs


Thanks,

Bill Farner

Re: Review Request 24241: Add test coverage for new client API methods.

Posted by Maxim Khutornenko <ma...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24241/#review49475
-----------------------------------------------------------

Ship it!


Thanks!

- Maxim Khutornenko


On Aug. 4, 2014, 6:29 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24241/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2014, 6:29 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add test coverage for new client API methods.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/api/scheduler_client.py 4b20efa0e8038b8fe85ecb85d842ebd89c5143d2 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 5c8ee52e1f4333babe153920fc6f65cdb2da2bd2 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py dd16fe2afe681f81e27f1eeddd5127b322934d74 
> 
> Diff: https://reviews.apache.org/r/24241/diff/
> 
> 
> Testing
> -------
> 
> ./pants src/test/python:all -vxs
> 
> 
> Thanks,
> 
> Bill Farner
> 
>