You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/12/27 10:43:57 UTC
[GitHub] [iotdb] ycycse opened a new pull request, #8631: [IOTDB-5278] fix connection problem of dbeaver and supports more functions
ycycse opened a new pull request, #8631:
URL: https://github.com/apache/iotdb/pull/8631
The dbeaver can connect normal after the PR.
And the dbeaver can show the device and column now.
Can be accessed through:
[iotdb-jdbc-1.0.1-SNAPSHOT-jar-with-dependencies.zip](https://github.com/apache/iotdb/files/10306840/iotdb-jdbc-1.0.1-SNAPSHOT-jar-with-dependencies.zip)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] JackieTien97 commented on a diff in pull request #8631: [To rel/1.0][IOTDB-5278] fix connection problem of dbeaver and supports more functions
Posted by GitBox <gi...@apache.org>.
JackieTien97 commented on code in PR #8631:
URL: https://github.com/apache/iotdb/pull/8631#discussion_r1057999016
##########
jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBDatabaseMetadata.java:
##########
@@ -1674,6 +1509,11 @@ public ResultSet getPrimaryKeys(String catalog, String schema, String table) thr
TSDataType.TEXT,
TSDataType.INT32,
TSDataType.TEXT);
+
+ String sg = "";
Review Comment:
never call it `sg`, we've already renamed it to `db` in new version.
##########
jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBDatabaseMetadata.java:
##########
@@ -1674,6 +1509,11 @@ public ResultSet getPrimaryKeys(String catalog, String schema, String table) thr
TSDataType.TEXT,
TSDataType.INT32,
TSDataType.TEXT);
+
+ String sg = "";
Review Comment:
check it in the following code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] ycycse commented on a diff in pull request #8631: [To rel/1.0][IOTDB-5278] fix connection problem of dbeaver and supports more functions
Posted by GitBox <gi...@apache.org>.
ycycse commented on code in PR #8631:
URL: https://github.com/apache/iotdb/pull/8631#discussion_r1058030044
##########
jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBDatabaseMetadata.java:
##########
@@ -1674,6 +1509,11 @@ public ResultSet getPrimaryKeys(String catalog, String schema, String table) thr
TSDataType.TEXT,
TSDataType.INT32,
TSDataType.TEXT);
+
+ String sg = "";
Review Comment:
the change has done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] JackieTien97 merged pull request #8631: [To rel/1.0][IOTDB-5278] fix connection problem of dbeaver and supports more functions
Posted by GitBox <gi...@apache.org>.
JackieTien97 merged PR #8631:
URL: https://github.com/apache/iotdb/pull/8631
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org