[GitHub] [incubator-pinot] apucher edited a comment on pull request #6515: use default broker and controller ports if not defined

[GitBox <gi...@apache.org>]

apucher edited a comment on pull request #6515:
URL: https://github.com/apache/incubator-pinot/pull/6515#issuecomment-771204637


   re high-level question:
   Pinot mingles two aspects - naming and discovery - and the helix InstanceConfig only supports a single port per instance. I worked around this restriction by decoupling naming (i.e. `inferPort()`) and using separate helix properties to represent and discover ports (e.g. `NETTYTLS_PORT_KEY`, `ADMIN_HTTPS_PORT_KEY`, ...)
   In other words, with the addition of listener specs, pinot's code doesn't rely on (or provides overrides for) Helix InstanceConfig ports in every place.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org