[GitHub] [spark] siying commented on a diff in pull request #41263: [SPARK-43333][SQL] Allow Avro to convert union type to SQL with field name stable with type

["siying (via GitHub)" <gi...@apache.org>]

siying commented on code in PR #41263:
URL: https://github.com/apache/spark/pull/41263#discussion_r1201365866


##########
connector/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala:
##########
@@ -98,6 +98,44 @@ abstract class AvroSuite
     }, new GenericDatumReader[Any]()).getSchema.toString(false)
   }
 
+  def checkUnionStableId(
+    types: List[Schema],
+    expectedSchema: String,
+    fieldsAndRow : Seq[(Any, Row)]): Unit = {

Review Comment:
   I copied the way SQL schema is generated from test "Complex Union Type". I feel it is easier to write unit test this way and if possible I will maintain it. I will add comments to explain the parameters.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org