You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2017/01/07 21:12:19 UTC

Review Request 55302: Improved OneWayPartitionTest.MasterToSlave.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55302/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Bugs: MESOS-6286
    https://issues.apache.org/jira/browse/MESOS-6286


Repository: mesos


Description
-------

Fix theoretical test flakiness (unlikely to be a problem in practice),
add more test expections, and cleanup code.


Diffs
-----

  src/tests/partition_tests.cpp 3afdbba13a9753edce17b24ff6d1898d3cc6de62 

Diff: https://reviews.apache.org/r/55302/diff/


Testing
-------

`make check`


Thanks,

Neil Conway

Re: Review Request 55302: Improved OneWayPartitionTest.MasterToSlave.

Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55302/
-----------------------------------------------------------

(Updated Jan. 9, 2017, 6:24 p.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Fix typo in comment.


Bugs: MESOS-6286
    https://issues.apache.org/jira/browse/MESOS-6286


Repository: mesos


Description
-------

Fix theoretical test flakiness (unlikely to be a problem in practice),
add more test expections, and cleanup code.


Diffs (updated)
-----

  src/tests/partition_tests.cpp 3afdbba13a9753edce17b24ff6d1898d3cc6de62 

Diff: https://reviews.apache.org/r/55302/diff/


Testing
-------

`make check`


Thanks,

Neil Conway

Re: Review Request 55302: Improved OneWayPartitionTest.MasterToSlave.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55302/#review160854
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/partition_tests.cpp (line 2523)
<https://reviews.apache.org/r/55302/#comment232085>

    s/receives/until it receives/ ?


- Vinod Kone


On Jan. 7, 2017, 9:12 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55302/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2017, 9:12 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6286
>     https://issues.apache.org/jira/browse/MESOS-6286
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix theoretical test flakiness (unlikely to be a problem in practice),
> add more test expections, and cleanup code.
> 
> 
> Diffs
> -----
> 
>   src/tests/partition_tests.cpp 3afdbba13a9753edce17b24ff6d1898d3cc6de62 
> 
> Diff: https://reviews.apache.org/r/55302/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>