You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "MalKeshar (via GitHub)" <gi...@apache.org> on 2024/03/07 20:18:31 UTC

[PR] Fix regex error in Log4j-config.xsd (logging-log4j2)

MalKeshar opened a new pull request, #2357:
URL: https://github.com/apache/logging-log4j2/pull/2357

   Trivial fix of error "The value of the facet 'pattern' is not a valid regular expression"
   
   Before:
   ```bash
   $ xmllint --schema Log4j-config.xsd /tmp/log4j2.xml --noout
   regexp error : failed to compile: Wrong escape sequence, misuse of character '\'
   regexp error : failed to compile: internal: no atom generated
   regexp error : failed to compile: generate transition: atom == NULL
   regexp error : failed to compile: xmlFAParseAtom: expecting ')'
   regexp error : failed to compile: xmlFAParseRegExp: extra characters
   Log4j-config.xsd:131: element pattern: Schemas parser error : Element '{[http://www.w3.org/2001/XMLSchema}pattern':](http://www.w3.org/2001/XMLSchema%7Dpattern':) The value '(|disable|\$\{[^{}]+\})' of the facet 'pattern' is not a valid regular expression.
   ```
   
   After:
   ```bash
   $ xmllint --schema log4j-core/src/main/resources/Log4j-config.xsd /tmp/log4j2.xml --noout
   /tmp/log4j2.xml validates
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix regex error in Log4j-config.xsd (logging-log4j2)

Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz closed pull request #2357: Fix regex error in Log4j-config.xsd
URL: https://github.com/apache/logging-log4j2/pull/2357


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix regex error in Log4j-config.xsd (logging-log4j2)

Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on PR #2357:
URL: https://github.com/apache/logging-log4j2/pull/2357#issuecomment-1985437499

   I am closing this, since we'll remove the manually written schema soon.
   
   I added a task pointing to this PR in the #1954 milestone.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix regex error in Log4j-config.xsd (logging-log4j2)

Posted by "vy (via GitHub)" <gi...@apache.org>.
vy commented on PR #2357:
URL: https://github.com/apache/logging-log4j2/pull/2357#issuecomment-1985280418

   @MalKeshar, thanks, much appreciated! The XSD misses a *huge* set of the available components and I am actively working on a project that will auto-generate this file from scratch. I expect to deliver a complete XSD within a couple of weeks. To avoid merge conflicts, and since there is a better solution in the making, I am inclined to close this PR. @ppkarwasz, thoughts?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org