[jira] [Updated] (BIGTOP-2536) tarball.destination is ignored when set

["Konstantin Boudnik (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BIGTOP-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated BIGTOP-2536:
---------------------------------------
    Attachment: 0001-BIGTOP-2536.-tarball.destination-is-ignored-when-set.patch

here's the patch. I would appreciate a second pair of eyes on this.

> tarball.destination is ignored when set
> ---------------------------------------
>
>                 Key: BIGTOP-2536
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-2536
>             Project: Bigtop
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 1.1.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 1.2.0
>
>         Attachments: 0001-BIGTOP-2536.-tarball.destination-is-ignored-when-set.patch
>
>
> There seems to be a bug in the current logic, assigning the destination filename of  a component artifact. Current logic does this
> {code}
>         if (!config.bigtop.components[target].tarball.source.isEmpty())
>           config.bigtop.components[target].downloaddst = DL_DIR + '/' + config.bigtop.components[target].tarball.source
> {code}
> which effectively ignores the destination filename. The potential issues could come if we build more than one component of a git repo (say GH), and all of those are downloading the master branch archive. In this case, the first component artifact will be stored as {{dl/master.zip}}, but the consequent component builds will simply skip the download part (as the {{master.zip}} is already present) and try to proceed with building a wrong source code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)