You are viewing a plain text version of this content. The canonical link for it is here.
Posted to xindice-dev@xml.apache.org by Dave Brosius <db...@qis.net> on 2004/07/12 13:22:36 UTC

Suspicious code

In org.apache.xindice.core.objects.Variant is this code

  public void set(Object object) {
      this.value = value;
      type = value != null ? Types.OBJECT
                           : Types.EMPTY;
   }

should this be 

this.value = object;
type = object != null .....

Re: Suspicious code

Posted by Vadim Gritsenko <va...@reverycodes.com>.
Dave Brosius wrote:

>Ah silly me, i just looked at the src in the distribution.
>  
>

:-)

If it makes you feel any better, download page at
    http://xml.apache.org/mirrors.cgi
is outdated a bit (does not list beta releases), our fault,but this one 
is up to date:
    http://xml.apache.org/xindice/download.cgi


Vadim


>----- Original Message ----- 
>From: "Vadim Gritsenko" <va...@reverycodes.com>
>To: <xi...@xml.apache.org>
>Sent: Monday, July 12, 2004 8:00 AM
>Subject: Re: Suspicious code
>
>
>  
>
>>Dave,
>>
>>Current Xindice version, 1.1b4, has no such package at all. Your efforts 
>>will be so much more appreciated if you take a look at current CVS HEAD 
>>version (it has couple of changes/bugfixes over b4 version).
>>
>>Thanks,
>>Vadim
>>
>>
>>Dave Brosius wrote:
>>
>>    
>>
>>>In org.apache.xindice.core.objects.Variant is this code
>>> 
>>>  public void set(Object object) {
>>>      this.value = value;
>>>      type = value != null ? Types.OBJECT
>>>                           : Types.EMPTY;
>>>   }
>>> 
>>>should this be
>>> 
>>>this.value = object;
>>>type = object != null .....
>>>      
>>>
>>
>>    
>>
>
>  
>

Re: Suspicious code

Posted by Dave Brosius <db...@qis.net>.
Ah silly me, i just looked at the src in the distribution.

----- Original Message ----- 
From: "Vadim Gritsenko" <va...@reverycodes.com>
To: <xi...@xml.apache.org>
Sent: Monday, July 12, 2004 8:00 AM
Subject: Re: Suspicious code


> Dave,
> 
> Current Xindice version, 1.1b4, has no such package at all. Your efforts 
> will be so much more appreciated if you take a look at current CVS HEAD 
> version (it has couple of changes/bugfixes over b4 version).
> 
> Thanks,
> Vadim
> 
> 
> Dave Brosius wrote:
> 
> > In org.apache.xindice.core.objects.Variant is this code
> >  
> >   public void set(Object object) {
> >       this.value = value;
> >       type = value != null ? Types.OBJECT
> >                            : Types.EMPTY;
> >    }
> >  
> > should this be
> >  
> > this.value = object;
> > type = object != null .....
> 
> 
>

Re: Suspicious code

Posted by Vadim Gritsenko <va...@reverycodes.com>.
Dave,

Current Xindice version, 1.1b4, has no such package at all. Your efforts 
will be so much more appreciated if you take a look at current CVS HEAD 
version (it has couple of changes/bugfixes over b4 version).

Thanks,
Vadim


Dave Brosius wrote:

> In org.apache.xindice.core.objects.Variant is this code
>  
>   public void set(Object object) {
>       this.value = value;
>       type = value != null ? Types.OBJECT
>                            : Types.EMPTY;
>    }
>  
> should this be
>  
> this.value = object;
> type = object != null .....