You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "lhotari (via GitHub)" <gi...@apache.org> on 2024/11/28 19:05:09 UTC
[PR] [fix][builds] Fix error "Element encoding is not allowed here" in pom.xml [pulsar]
lhotari opened a new pull request, #23655:
URL: https://github.com/apache/pulsar/pull/23655
### Motivation
IntelliJ shows an xml error in pom.xml, "Element encoding is not allowed here"
<img width="835" alt="image" src="https://github.com/user-attachments/assets/51452ccd-ac02-4f0a-ac23-4d06da991603">
### Modifications
- use `inputEncoding` and `outputEncoding` (when applicable) instead of `encoding`
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][build] Fix error "Element encoding is not allowed here" in pom.xml [pulsar]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #23655:
URL: https://github.com/apache/pulsar/pull/23655#issuecomment-2506834638
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/23655?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 74.33%. Comparing base [(`bbc6224`)](https://app.codecov.io/gh/apache/pulsar/commit/bbc62245c5ddba1de4b1e7cee4ab49334bc36277?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`b382bdb`)](https://app.codecov.io/gh/apache/pulsar/commit/b382bdb24474b8d414355e4653a4e19fc541bdda?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 760 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/pulsar/pull/23655?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #23655 +/- ##
============================================
+ Coverage 73.57% 74.33% +0.76%
- Complexity 32624 34481 +1857
============================================
Files 1877 1944 +67
Lines 139502 147242 +7740
Branches 15299 16250 +951
============================================
+ Hits 102638 109452 +6814
- Misses 28908 29335 +427
- Partials 7956 8455 +499
```
| [Flag](https://app.codecov.io/gh/apache/pulsar/pull/23655/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [inttests](https://app.codecov.io/gh/apache/pulsar/pull/23655/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `27.30% <ø> (+2.71%)` | :arrow_up: |
| [systests](https://app.codecov.io/gh/apache/pulsar/pull/23655/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `24.38% <ø> (+0.05%)` | :arrow_up: |
| [unittests](https://app.codecov.io/gh/apache/pulsar/pull/23655/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.72% <ø> (+0.87%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 668 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/23655/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][build] Fix error "Element encoding is not allowed here" in pom.xml [pulsar]
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- merged PR #23655:
URL: https://github.com/apache/pulsar/pull/23655
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org