[GitHub] [maven-resolver] psiroky commented on pull request #243: [MRESOLVER-320] Return to original pool setup

["psiroky (via GitHub)" <gi...@apache.org>]

psiroky commented on PR #243:
URL: https://github.com/apache/maven-resolver/pull/243#issuecomment-1430456033

   I will run some more tests tomorrow. So far I just tried to run the `validate -Dversion.enforcer.plugin=3.2.1 -T8` (on Quarkus again), which seems to be almost on par with Maven 3.8.7 (9s vs 9.3s, and vs 11s for Maven 3.9.0).
   
   However, I also got this exception in one of the runs
   ```
   Caused by: java.lang.NullPointerException: Cannot invoke "org.eclipse.aether.graph.Dependency.getArtifact()" because "dependency" is null
       at org.eclipse.aether.internal.impl.collect.DefaultDependencyCollectionContext.set (DefaultDependencyCollectionContext.java:75)
       at org.eclipse.aether.internal.impl.collect.df.DfDependencyCollector.doRecurse (DfDependencyCollector.java:261)
       at org.eclipse.aether.internal.impl.collect.df.DfDependencyCollector.processDependency (DfDependencyCollector.java:236)
       at org.eclipse.aether.internal.impl.collect.df.DfDependencyCollector.processDependency (DfDependencyCollector.java:137)
       at org.eclipse.aether.internal.impl.collect.df.DfDependencyCollector.process (DfDependencyCollector.java:125)
       at org.eclipse.aether.internal.impl.collect.df.DfDependencyCollector.doRecurse (DfDependencyCollector.java:284)
       at org.eclipse.aether.internal.impl.collect.df.DfDependencyCollector.processDependency (DfDependencyCollector.java:236)
       at org.eclipse.aether.internal.impl.collect.df.DfDependencyCollector.processDependency (DfDependencyCollector.java:137)
       at org.eclipse.aether.internal.impl.collect.df.DfDependencyCollector.process (DfDependencyCollector.java:125)
       at org.eclipse.aether.internal.impl.collect.df.DfDependencyCollector.doCollectDependencies (DfDependencyCollector.java:107)
       at org.eclipse.aether.internal.impl.collect.DependencyCollectorDelegate.collectDependencies (DependencyCollectorDelegate.java:247)
       at org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.collectDependencies (DefaultDependencyCollector.java:95)
       at org.eclipse.aether.internal.impl.DefaultRepositorySystem.collectDependencies (DefaultRepositorySystem.java:327)
       at org.apache.maven.enforcer.rules.dependency.ResolveUtil.resolveTransitiveDependencies (ResolveUtil.java:101)
       at org.apache.maven.enforcer.rules.dependency.DependencyConvergence.execute (DependencyConvergence.java:65)
       at org.apache.maven.plugins.enforcer.EnforceMojo.executeRuleNew (EnforceMojo.java:351)
       at org.apache.maven.plugins.enforcer.EnforceMojo.executeRule (EnforceMojo.java:325)
       at org.apache.maven.plugins.enforcer.EnforceMojo.execute (EnforceMojo.java:248)
       at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:126)
       at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:342)
       at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:330)
       at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:213)
       at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:175)
       at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 (MojoExecutor.java:76)
       at org.apache.maven.lifecycle.internal.MojoExecutor$1.run (MojoExecutor.java:163)
       at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute (DefaultMojosExecutionStrategy.java:39)
       at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:160)
       at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:105)
       at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call (MultiThreadedBuilder.java:193)
       at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call (MultiThreadedBuilder.java:180)
       at java.util.concurrent.FutureTask.run (FutureTask.java:317)
       at java.util.concurrent.Executors$RunnableAdapter.call (Executors.java:577)
       at java.util.concurrent.FutureTask.run (FutureTask.java:317)
       at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1144)
       at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:642)
       at java.lang.Thread.run (Thread.java:1589)
   
   ```
   
   I am not sure if this is related to these changes, but it seemed suspicious as it is coming from the `DfDependencyCollector`, so figured I would mention it here. It is quite rare, I only got this error once in 100 runs (so maybe this there all the time and I was just "lucky" to never encounter it). In any case, it seems like something we should eventually take a look at.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org