You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "Tobias Bocanegra (JIRA)" <ji...@apache.org> on 2016/02/23 07:53:18 UTC
[jira] [Comment Edited] (CB-10603) Harmonize the use of
[ios|osx]-CFBundle[Identifier|version]
[ https://issues.apache.org/jira/browse/CB-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15158410#comment-15158410 ]
Tobias Bocanegra edited comment on CB-10603 at 2/23/16 6:52 AM:
----------------------------------------------------------------
the current commons code uses {{ios-CFBundleVersion}} and {{ios-CFBundleIdentifier}}:
- https://github.com/apache/cordova-lib/blob/6.0.0/cordova-common/src/ConfigParser/ConfigParser.js#L106
- https://github.com/apache/cordova-lib/blob/6.0.0/cordova-common/src/ConfigParser/ConfigParser.js#L132
Now with OSX in the game there could be similar new attributes {{osx-CFBundleVersion}} and {{osx-CFBundleIdentifier}} or we could deprecate the {{ios-*}} ones and just use their plain names without prefix.
suggest:
- use {{CFBundleVersion}} and {{CFBundleIdentifier}} of iOS and OSX platform.
- deprecate {{ios-CFBundleVersion}} and {{ios-CFBundleIdentifier}}
drawback:
- using the un-prefixed attribute names would prevent a project of having different versions/identifiers for the ios and osx platforms. if one wants to evolve them separately, it would then need to use some hooks to tweak the config.xml.
counter argument:
- windows and android also use prefixed versions, so maybe its better to keep this pattern consistent.
was (Author: tripod):
the current commons code uses {{ios-CFBundleVersion}} and {{ios-CFBundleIdentifier}}:
- https://github.com/apache/cordova-lib/blob/6.0.0/cordova-common/src/ConfigParser/ConfigParser.js#L106
- https://github.com/apache/cordova-lib/blob/6.0.0/cordova-common/src/ConfigParser/ConfigParser.js#L132
Now with OSX in the game there could be similar new attributes {{osx-CFBundleVersion}} and {{osx-CFBundleIdentifier}} or we could deprecate the {{ios-*}} ones and just use their plain names without prefix.
suggest:
- use {{CFBundleVersion}} and {{CFBundleIdentifier}} of iOS and OSX platform.
- deprecate {{ios-CFBundleVersion}} and {{ios-CFBundleIdentifier}}
drawback:
- using the un-prefixed attribute names would prevent a project of having different versions/identifiers for the ios and osx platforms. if one wants to evolve them separately, it would then need to use some hooks to tweak the config.xml.
> Harmonize the use of [ios|osx]-CFBundle[Identifier|version]
> -----------------------------------------------------------
>
> Key: CB-10603
> URL: https://issues.apache.org/jira/browse/CB-10603
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS, OSX
> Reporter: Tobias Bocanegra
> Assignee: Tobias Bocanegra
> Labels: triaged
>
> There seems to be a mismatch with the use of ios_CFBundleIdentifier and osx_CFBundleIndentifier:
> - https://github.com/apache/cordova-osx/blob/cbfa7a531bb2a0a0e39fda14edaaff0e4a146b63/bin/templates/scripts/cordova/lib/prepare.js#L131
> - https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/metadata/osx_parser.js#L71
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org