You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/01 08:18:02 UTC

[GitHub] [flink] MartijnVisser commented on a change in pull request #19303: [FLINK-26961][connectors][filesystems][formats] Update multiple Jacks…

MartijnVisser commented on a change in pull request #19303:
URL: https://github.com/apache/flink/pull/19303#discussion_r840341267



##########
File path: flink-connectors/flink-sql-connector-elasticsearch7/src/main/resources/META-INF/NOTICE
##########
@@ -7,12 +7,12 @@ The Apache Software Foundation (http://www.apache.org/).
 This project bundles the following dependencies under the Apache Software License 2.0. (http://www.apache.org/licenses/LICENSE-2.0.txt)
 
 - com.carrotsearch:hppc:0.8.1
-- com.fasterxml.jackson.core:jackson-core:2.13.0
-- com.fasterxml.jackson.core:jackson-databind:2.13.0
-- com.fasterxml.jackson.core:jackson-annotations:2.13.0
-- com.fasterxml.jackson.dataformat:jackson-dataformat-cbor:2.13.0
-- com.fasterxml.jackson.dataformat:jackson-dataformat-smile:2.13.0
-- com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.13.0
+- com.fasterxml.jackson.core:jackson-core:2.13.2
+- com.fasterxml.jackson.core:jackson-databind:2.13.2.1

Review comment:
       Also to 2.13.2.1 ? 

##########
File path: flink-connectors/flink-connector-kinesis/src/main/resources/META-INF/NOTICE
##########
@@ -55,7 +55,7 @@ This project bundles the following dependencies under the Apache Software Licens
 - com.typesafe.netty:netty-reactive-streams-http:2.0.5
 - com.typesafe.netty:netty-reactive-streams:2.0.5
 - commons-logging:commons-logging:1.1.3
-- com.fasterxml.jackson.core:jackson-core:2.13.0
+- com.fasterxml.jackson.core:jackson-core:2.13.2

Review comment:
       Could we actually bump this to 2.13.2.2 ? Looks like 2.13.2 still has a vulnerability according to https://mvnrepository.com/artifact/com.fasterxml.jackson.core/jackson-databind

##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-aws-kinesis-firehose/pom.xml
##########
@@ -72,19 +72,19 @@
 		<dependency>
 			<groupId>com.fasterxml.jackson.core</groupId>
 			<artifactId>jackson-core</artifactId>
-			<version>2.13.0</version>
+			<version>2.13.2</version>
 		</dependency>
 
 		<dependency>
 			<groupId>com.fasterxml.jackson.core</groupId>
 			<artifactId>jackson-annotations</artifactId>
-			<version>2.13.0</version>
+			<version>2.13.2</version>
 		</dependency>
 
 		<dependency>
 			<groupId>com.fasterxml.jackson.core</groupId>
 			<artifactId>jackson-databind</artifactId>
-			<version>2.13.0</version>
+			<version>2.13.2.1</version>

Review comment:
       ```suggestion
   			<version>2.13.2.2</version>
   ```

##########
File path: flink-connectors/flink-sql-connector-kinesis/src/main/resources/META-INF/NOTICE
##########
@@ -14,7 +14,7 @@ This project bundles the following dependencies under the Apache Software Licens
 - org.apache.commons:commons-lang3:3.3.2
 - com.google.guava:guava:29.0-jre
 - com.google.guava:failureaccess:1.0.1
-- com.fasterxml.jackson.core:jackson-annotations:2.13.0
-- com.fasterxml.jackson.core:jackson-databind:2.13.0
-- com.fasterxml.jackson.core:jackson-core:2.13.0
-- com.fasterxml.jackson.dataformat:jackson-dataformat-cbor:2.13.0
+- com.fasterxml.jackson.core:jackson-annotations:2.13.2
+- com.fasterxml.jackson.core:jackson-databind:2.13.2.1
+- com.fasterxml.jackson.core:jackson-core:2.13.2

Review comment:
       Same

##########
File path: flink-connectors/flink-connector-kinesis/src/main/resources/META-INF/NOTICE
##########
@@ -55,7 +55,7 @@ This project bundles the following dependencies under the Apache Software Licens
 - com.typesafe.netty:netty-reactive-streams-http:2.0.5
 - com.typesafe.netty:netty-reactive-streams:2.0.5
 - commons-logging:commons-logging:1.1.3
-- com.fasterxml.jackson.core:jackson-core:2.13.0
+- com.fasterxml.jackson.core:jackson-core:2.13.2

Review comment:
       ```suggestion
   - com.fasterxml.jackson.core:jackson-core:2.13.2.2
   ```

##########
File path: flink-connectors/flink-sql-connector-kinesis/src/main/resources/META-INF/NOTICE
##########
@@ -14,7 +14,7 @@ This project bundles the following dependencies under the Apache Software Licens
 - org.apache.commons:commons-lang3:3.3.2
 - com.google.guava:guava:29.0-jre
 - com.google.guava:failureaccess:1.0.1
-- com.fasterxml.jackson.core:jackson-annotations:2.13.0
-- com.fasterxml.jackson.core:jackson-databind:2.13.0
-- com.fasterxml.jackson.core:jackson-core:2.13.0
-- com.fasterxml.jackson.dataformat:jackson-dataformat-cbor:2.13.0
+- com.fasterxml.jackson.core:jackson-annotations:2.13.2
+- com.fasterxml.jackson.core:jackson-databind:2.13.2.1
+- com.fasterxml.jackson.core:jackson-core:2.13.2

Review comment:
       ```suggestion
   - com.fasterxml.jackson.core:jackson-databind:2.13.2.2
   - com.fasterxml.jackson.core:jackson-core:2.13.2.2
   ```

##########
File path: flink-filesystems/flink-azure-fs-hadoop/src/main/resources/META-INF/NOTICE
##########
@@ -6,7 +6,7 @@ The Apache Software Foundation (http://www.apache.org/).
 
 This project bundles the following dependencies under the Apache Software License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt)
 
-- com.fasterxml.jackson.core:jackson-core:2.13.0
+- com.fasterxml.jackson.core:jackson-core:2.13.2

Review comment:
       ```suggestion
   - com.fasterxml.jackson.core:jackson-core:2.13.2.2
   ```

##########
File path: flink-filesystems/flink-s3-fs-presto/src/main/resources/META-INF/NOTICE
##########
@@ -22,10 +22,10 @@ This project bundles the following dependencies under the Apache Software Licens
 - com.facebook.presto:presto-hive-common:0.257
 - com.facebook.presto:presto-hive-metastore:0.257
 - com.facebook.presto.hadoop:hadoop-apache2:2.7.4-9
-- com.fasterxml.jackson.core:jackson-annotations:2.13.0
-- com.fasterxml.jackson.core:jackson-core:2.13.0
-- com.fasterxml.jackson.core:jackson-databind:2.13.0
-- com.fasterxml.jackson.dataformat:jackson-dataformat-cbor:2.13.0
+- com.fasterxml.jackson.core:jackson-annotations:2.13.2
+- com.fasterxml.jackson.core:jackson-core:2.13.2
+- com.fasterxml.jackson.core:jackson-databind:2.13.2.1

Review comment:
       ```suggestion
   - com.fasterxml.jackson.core:jackson-core:2.13.2.2
   - com.fasterxml.jackson.core:jackson-databind:2.13.2.2
   ```

##########
File path: flink-filesystems/flink-fs-hadoop-shaded/src/main/resources/META-INF/NOTICE
##########
@@ -22,9 +22,9 @@ This project bundles the following dependencies under the Apache Software Licens
 - com.google.guava:guava:27.0-jre
 - com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
 - com.google.j2objc:j2objc-annotations:1.1
-- com.fasterxml.jackson.core:jackson-annotations:2.13.0
-- com.fasterxml.jackson.core:jackson-core:2.13.0
-- com.fasterxml.jackson.core:jackson-databind:2.13.0
+- com.fasterxml.jackson.core:jackson-annotations:2.13.2
+- com.fasterxml.jackson.core:jackson-core:2.13.2
+- com.fasterxml.jackson.core:jackson-databind:2.13.2.1

Review comment:
       ```suggestion
   - com.fasterxml.jackson.core:jackson-core:2.13.2.2
   - com.fasterxml.jackson.core:jackson-databind:2.13.2.2
   ```

##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-aws-kinesis-firehose/pom.xml
##########
@@ -72,19 +72,19 @@
 		<dependency>
 			<groupId>com.fasterxml.jackson.core</groupId>
 			<artifactId>jackson-core</artifactId>
-			<version>2.13.0</version>
+			<version>2.13.2</version>

Review comment:
       ```suggestion
   			<version>2.13.2.2</version>
   ```

##########
File path: flink-connectors/flink-sql-connector-elasticsearch6/src/main/resources/META-INF/NOTICE
##########
@@ -6,12 +6,12 @@ The Apache Software Foundation (http://www.apache.org/).
 
 This project bundles the following dependencies under the Apache Software License 2.0. (http://www.apache.org/licenses/LICENSE-2.0.txt)
 
-- com.fasterxml.jackson.core:jackson-core:2.13.0
-- com.fasterxml.jackson.core:jackson-databind:2.13.0
-- com.fasterxml.jackson.core:jackson-annotations:2.13.0
-- com.fasterxml.jackson.dataformat:jackson-dataformat-cbor:2.13.0
-- com.fasterxml.jackson.dataformat:jackson-dataformat-smile:2.13.0
-- com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.13.0
+- com.fasterxml.jackson.core:jackson-core:2.13.2
+- com.fasterxml.jackson.core:jackson-databind:2.13.2.1

Review comment:
       Same here, could we bump them to 2.13.2.2 ? 

##########
File path: flink-formats/flink-sql-avro/src/main/resources/META-INF/NOTICE
##########
@@ -7,7 +7,7 @@ The Apache Software Foundation (http://www.apache.org/).
 This project bundles the following dependencies under the Apache Software License 2.0. (http://www.apache.org/licenses/LICENSE-2.0.txt)
 
 - org.apache.avro:avro:1.10.0
-- com.fasterxml.jackson.core:jackson-core:2.13.0
-- com.fasterxml.jackson.core:jackson-databind:2.13.0
-- com.fasterxml.jackson.core:jackson-annotations:2.13.0
+- com.fasterxml.jackson.core:jackson-core:2.13.2
+- com.fasterxml.jackson.core:jackson-databind:2.13.2.1

Review comment:
       ```suggestion
   - com.fasterxml.jackson.core:jackson-core:2.13.2.2
   - com.fasterxml.jackson.core:jackson-databind:2.13.2.2
   ```

##########
File path: flink-kubernetes/src/main/resources/META-INF/NOTICE
##########
@@ -6,11 +6,11 @@ The Apache Software Foundation (http://www.apache.org/).
 
 This project bundles the following dependencies under the Apache Software License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt)
 
-- com.fasterxml.jackson.core:jackson-annotations:2.13.0
-- com.fasterxml.jackson.core:jackson-core:2.13.0
-- com.fasterxml.jackson.core:jackson-databind:2.13.0
-- com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.13.0
-- com.fasterxml.jackson.datatype:jackson-datatype-jsr310:2.13.0
+- com.fasterxml.jackson.core:jackson-annotations:2.13.2
+- com.fasterxml.jackson.core:jackson-core:2.13.2
+- com.fasterxml.jackson.core:jackson-databind:2.13.2.1

Review comment:
       ```suggestion
   - com.fasterxml.jackson.core:jackson-core:2.13.2.2
   - com.fasterxml.jackson.core:jackson-databind:2.13.2.2
   ```

##########
File path: flink-connectors/flink-sql-connector-elasticsearch6/src/main/resources/META-INF/NOTICE
##########
@@ -6,12 +6,12 @@ The Apache Software Foundation (http://www.apache.org/).
 
 This project bundles the following dependencies under the Apache Software License 2.0. (http://www.apache.org/licenses/LICENSE-2.0.txt)
 
-- com.fasterxml.jackson.core:jackson-core:2.13.0
-- com.fasterxml.jackson.core:jackson-databind:2.13.0
-- com.fasterxml.jackson.core:jackson-annotations:2.13.0
-- com.fasterxml.jackson.dataformat:jackson-dataformat-cbor:2.13.0
-- com.fasterxml.jackson.dataformat:jackson-dataformat-smile:2.13.0
-- com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.13.0
+- com.fasterxml.jackson.core:jackson-core:2.13.2
+- com.fasterxml.jackson.core:jackson-databind:2.13.2.1

Review comment:
       ```suggestion
   - com.fasterxml.jackson.core:jackson-core:2.13.2.2
   - com.fasterxml.jackson.core:jackson-databind:2.13.2.2
   ```

##########
File path: flink-connectors/flink-sql-connector-elasticsearch7/src/main/resources/META-INF/NOTICE
##########
@@ -7,12 +7,12 @@ The Apache Software Foundation (http://www.apache.org/).
 This project bundles the following dependencies under the Apache Software License 2.0. (http://www.apache.org/licenses/LICENSE-2.0.txt)
 
 - com.carrotsearch:hppc:0.8.1
-- com.fasterxml.jackson.core:jackson-core:2.13.0
-- com.fasterxml.jackson.core:jackson-databind:2.13.0
-- com.fasterxml.jackson.core:jackson-annotations:2.13.0
-- com.fasterxml.jackson.dataformat:jackson-dataformat-cbor:2.13.0
-- com.fasterxml.jackson.dataformat:jackson-dataformat-smile:2.13.0
-- com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.13.0
+- com.fasterxml.jackson.core:jackson-core:2.13.2
+- com.fasterxml.jackson.core:jackson-databind:2.13.2.1

Review comment:
       ```suggestion
   - com.fasterxml.jackson.core:jackson-core:2.13.2.2
   - com.fasterxml.jackson.core:jackson-databind:2.13.2.2
   ```

##########
File path: flink-formats/flink-sql-avro-confluent-registry/src/main/resources/META-INF/NOTICE
##########
@@ -7,9 +7,9 @@ The Apache Software Foundation (http://www.apache.org/).
 This project bundles the following dependencies under the Apache Software License 2.0. (http://www.apache.org/licenses/LICENSE-2.0.txt)
 
 - org.apache.avro:avro:1.10.0
-- com.fasterxml.jackson.core:jackson-core:2.13.0
-- com.fasterxml.jackson.core:jackson-databind:2.13.0
-- com.fasterxml.jackson.core:jackson-annotations:2.13.0
+- com.fasterxml.jackson.core:jackson-core:2.13.2
+- com.fasterxml.jackson.core:jackson-databind:2.13.2.1

Review comment:
       ```suggestion
   - com.fasterxml.jackson.core:jackson-core:2.13.2.2
   - com.fasterxml.jackson.core:jackson-databind:2.13.2.2
   ```

##########
File path: flink-filesystems/flink-s3-fs-hadoop/src/main/resources/META-INF/NOTICE
##########
@@ -9,10 +9,10 @@ This project bundles the following dependencies under the Apache Software Licens
 - com.amazonaws:aws-java-sdk-s3:1.11.951
 - com.amazonaws:aws-java-sdk-sts:1.11.951
 - com.amazonaws:jmespath-java:1.11.951
-- com.fasterxml.jackson.core:jackson-annotations:2.13.0
-- com.fasterxml.jackson.core:jackson-core:2.13.0
-- com.fasterxml.jackson.core:jackson-databind:2.13.0
-- com.fasterxml.jackson.dataformat:jackson-dataformat-cbor:2.13.0
+- com.fasterxml.jackson.core:jackson-annotations:2.13.2
+- com.fasterxml.jackson.core:jackson-core:2.13.2
+- com.fasterxml.jackson.core:jackson-databind:2.13.2.1

Review comment:
       ```suggestion
   - com.fasterxml.jackson.core:jackson-core:2.13.2.2
   - com.fasterxml.jackson.core:jackson-databind:2.13.2.2
   ```

##########
File path: flink-python/src/main/resources/META-INF/NOTICE
##########
@@ -6,9 +6,9 @@ The Apache Software Foundation (http://www.apache.org/).
 
 This project bundles the following dependencies under the Apache Software License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt)
 
-- com.fasterxml.jackson.core:jackson-annotations:2.13.0
-- com.fasterxml.jackson.core:jackson-core:2.13.0
-- com.fasterxml.jackson.core:jackson-databind:2.13.0
+- com.fasterxml.jackson.core:jackson-annotations:2.13.2
+- com.fasterxml.jackson.core:jackson-core:2.13.2
+- com.fasterxml.jackson.core:jackson-databind:2.13.2.1

Review comment:
       ```suggestion
   - com.fasterxml.jackson.core:jackson-core:2.13.2.2
   - com.fasterxml.jackson.core:jackson-databind:2.13.2.2
   ```

##########
File path: flink-filesystems/flink-gs-fs-hadoop/src/main/resources/META-INF/NOTICE
##########
@@ -6,7 +6,7 @@ The Apache Software Foundation (http://www.apache.org/).
 
 This project bundles the following dependencies under the Apache Software License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt)
 
-- com.fasterxml.jackson.core:jackson-core:2.13.0
+- com.fasterxml.jackson.core:jackson-core:2.13.2

Review comment:
       ```suggestion
   - com.fasterxml.jackson.core:jackson-core:2.13.2.2
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org