You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@singa.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2015/09/04 12:05:45 UTC

[jira] [Commented] (SINGA-21) Code Review

    [ https://issues.apache.org/jira/browse/SINGA-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14730589#comment-14730589 ] 

ASF subversion and git services commented on SINGA-21:
------------------------------------------------------

Commit f99246e7840eb5fcec2918b37736cba0344db19e in incubator-singa's branch refs/heads/master from wang sheng
[ https://git-wip-us.apache.org/repos/asf?p=incubator-singa.git;h=f99246e ]

SINGA-21 Code review 4

review param.h, param.cc
  - ShareFrom(): init vectors by resizing instead of assignning
  - add a summary for put/get/update/sync request workflows
  - implement reserve flags correctly for all HandleXX functions
    TODO: remove all reserve-flag checks later
  - format the code

format update.h, updater.cc


> Code Review
> -----------
>
>                 Key: SINGA-21
>                 URL: https://issues.apache.org/jira/browse/SINGA-21
>             Project: Singa
>          Issue Type: Task
>            Reporter: Sheng Wang
>            Assignee: Sheng Wang
>
> Clean the code for first release.
> Code style follows google c++ code style(https://google-styleguide.googlecode.com/svn/trunk/cppguide.html).
> Style check tool cpplint(http://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py) is recommanded to help clean the code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)