You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "magpierre (via GitHub)" <gi...@apache.org> on 2024/11/07 17:44:16 UTC
[PR] (FIX Issue #87) Correct Config to accurately set UserContext [spark-connect-go]
magpierre opened a new pull request, #88:
URL: https://github.com/apache/spark-connect-go/pull/88
The proto lacked userContext which led to not able to set values correctly for current session & user context.
### What changes were proposed in this pull request?
client.Config() function proto lacked UserContext
### Why are the changes needed?
photo requires a user context that was actually omitted in the development and was not caught since the call seemingly work, but does not set the value in the correct context.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Setting spark.sql.ansi.enabled to true (default false) and running a ansi violation cast as well as getting the value from spark.sql using set and using Config.Get in a golang application.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] (FIX Issue #87) Correct Config to accurately set UserContext [spark-connect-go]
Posted by "grundprinzip (via GitHub)" <gi...@apache.org>.
grundprinzip commented on PR #88:
URL: https://github.com/apache/spark-connect-go/pull/88#issuecomment-2463163680
Thanks for the fix, merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] (FIX Issue #87) Correct Config to accurately set UserContext [spark-connect-go]
Posted by "grundprinzip (via GitHub)" <gi...@apache.org>.
grundprinzip closed pull request #88: (FIX Issue #87) Correct Config to accurately set UserContext
URL: https://github.com/apache/spark-connect-go/pull/88
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org