[GitHub] [beam] amaliujia commented on a change in pull request #13630: [BEAM-11536] Test custom WindowFn in WindowStrategyTranslation

[GitBox <gi...@apache.org>]

amaliujia commented on a change in pull request #13630:
URL: https://github.com/apache/beam/pull/13630#discussion_r549883174



##########
File path: runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/WindowingStrategyTranslationTest.java
##########
@@ -143,4 +162,142 @@ public void testToProtoAndBackWithComponents() throws Exception {
         proto.getAssignsToOneWindow(),
         equalTo(windowingStrategy.getWindowFn().assignsToOneWindow()));
   }
+
+  private static class CustomWindow extends IntervalWindow {

Review comment:
       Yes. This is the one I want to use to test gradually and finally to make custom WindowFn work. Right now it is only private as it is used within this test. In the further as I find more place to add tests I can move this class out accordingly.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org