You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by audreyso <gi...@git.apache.org> on 2017/03/10 23:06:52 UTC
[GitHub] cordova-lib pull request #526: CB-11242 - Removed platform-specific code for...
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/526
CB-11242 - Removed platform-specific code for platforms w/ PlatformApi implemented
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### What does this PR do?
Removed platform-specific code for platforms w/ PlatformApi implemented (ios, android, windows).
Android testing files also updated.
### What testing has been done on this change?
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [X] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/audreyso/cordova-lib CB-11242
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/526.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #526
----
commit d0670a566a67bb8735577c3ba44f8daba060c196
Author: Audrey So <au...@apache.org>
Date: 2017-03-03T18:28:50Z
CB-11242 : removed parser and handler files for ios, windows, and android and added cordova dir to android test in fixtures dir and removed uninstall android files because causing errors
commit a0b1f6b8ad88b7df941ffa6d953162f678a463ad
Author: Audrey So <au...@apache.org>
Date: 2017-03-07T18:12:29Z
CB-11242 - updated android install tests to use new files, fixed installed tests by updating dummy plugin files, and updated android test files to use most recent files available
commit cc66c8656405e2329cedd186f8871de92fac8f8c
Author: Audrey So <au...@apache.org>
Date: 2017-03-09T20:00:56Z
CB-11242 : updated plugin.spec test to use original plugin version, use android test files, and comment out test 002 - does not call prepare anymore and added node_modules dir
commit cfda10d14be34505bfa062534be5e8fd5776997e
Author: Audrey So <au...@apache.org>
Date: 2017-03-10T21:32:49Z
CB-11242 : added new browser test files to support PlatformApiPoly.spec.js tests
commit 8ba0df74df6765ec520111db3e3ed417591fde22
Author: Audrey So <au...@apache.org>
Date: 2017-03-10T22:00:12Z
CB-11242 : updated platformApi android test files and updated platforms.spec to use browser instead of android
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #526: CB-11242 - Removed platform-specific code for...
Posted by audreyso <gi...@git.apache.org>.
Github user audreyso closed the pull request at:
https://github.com/apache/cordova-lib/pull/526
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #526: CB-11242 - Removed platform-specific code for platfo...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-lib/pull/526
# [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/526?src=pr&el=h1) Report
> Merging [#526](https://codecov.io/gh/apache/cordova-lib/pull/526?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-lib/commit/07001dc4e0acf89358c50791589428615198286b?src=pr&el=desc) will **decrease** coverage by `2.26%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #526 +/- ##
==========================================
- Coverage 81.9% 79.63% -2.27%
==========================================
Files 68 60 -8
Lines 5498 4272 -1226
Branches 1090 890 -200
==========================================
- Hits 4503 3402 -1101
+ Misses 995 870 -125
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-lib/pull/526?src=pr&el=tree) | Coverage \u0394 | |
|---|---|---|
| [cordova-lib/src/platforms/platforms.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...73d0f49671b73d44b189418ced34c075ae99decf?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsYXRmb3Jtcy9wbGF0Zm9ybXMuanM=) | `87.87% <0%> (-8.68%)` | :x: |
| [cordova-lib/src/plugman/platforms/common.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...73d0f49671b73d44b189418ced34c075ae99decf?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsdWdtYW4vcGxhdGZvcm1zL2NvbW1vbi5qcw==) | `85.26% <0%> (-8.43%)` | :x: |
| [cordova-lib/src/cordova/config.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...73d0f49671b73d44b189418ced34c075ae99decf?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvY29uZmlnLmpz) | `70% <0%> (-5%)` | :x: |
| [cordova-lib/src/platforms/PlatformApiPoly.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...73d0f49671b73d44b189418ced34c075ae99decf?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsYXRmb3Jtcy9QbGF0Zm9ybUFwaVBvbHkuanM=) | `91.86% <0%> (-2.33%)` | :x: |
| [cordova-lib/src/cordova/platform.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...73d0f49671b73d44b189418ced34c075ae99decf?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvcGxhdGZvcm0uanM=) | `77.23% <0%> (-1.02%)` | :x: |
| [cordova-lib/src/plugman/install.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...73d0f49671b73d44b189418ced34c075ae99decf?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsdWdtYW4vaW5zdGFsbC5qcw==) | `87.16% <0%> (�)` | :white_check_mark: |
| [cordova-lib/src/plugman/platforms/android.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...73d0f49671b73d44b189418ced34c075ae99decf?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsdWdtYW4vcGxhdGZvcm1zL2FuZHJvaWQuanM=) | | |
| [cordova-lib/src/plugman/util/android-project.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...73d0f49671b73d44b189418ced34c075ae99decf?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsdWdtYW4vdXRpbC9hbmRyb2lkLXByb2plY3QuanM=) | | |
| [cordova-lib/src/util/windows/jsprojManager.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...73d0f49671b73d44b189418ced34c075ae99decf?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3V0aWwvd2luZG93cy9qc3Byb2pNYW5hZ2VyLmpz) | | |
| [cordova-lib/src/plugman/platforms/ios.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...73d0f49671b73d44b189418ced34c075ae99decf?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsdWdtYW4vcGxhdGZvcm1zL2lvcy5qcw==) | | |
| ... and [5 more](https://codecov.io/gh/apache/cordova-lib/pull/526?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/526?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `\u0394 = absolute <relative> (impact)`, `� = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/526?src=pr&el=footer). Last update [07001dc...73d0f49](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...73d0f49671b73d44b189418ced34c075ae99decf?src=pr&el=footer&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #526: CB-11242 - Removed platform-specific code for...
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/526#discussion_r108041377
--- Diff: cordova-lib/src/platforms/platformsConfig.json ---
@@ -11,15 +9,12 @@
"osx": {
"hostos": ["darwin"],
"parser_file": "../cordova/metadata/osx_parser",
- "handler_file": "../plugman/platforms/ios",
--- End diff --
hmm, this might be an issue. OSX uses ios handler file. Maybe make a copy of `../plugman/platforms/ios` and rename it to `../plugman/platforms/osx` and update this file to use the copy
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #526: CB-11242 - Removed platform-specific code for...
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/526#discussion_r108041118
--- Diff: cordova-lib/spec-cordova/fixtures/projects/platformApi/platforms/android/.gitignore ---
@@ -0,0 +1,14 @@
+# Non-project-specific build files:
--- End diff --
don't think you need this file
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org