You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2014/02/10 17:01:56 UTC
Review Request 17904: Host health status should ignore host components in
Out-of-Service (passive) mode
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17904/
-----------------------------------------------------------
Review request for Ambari, Sid Wagle and Tom Beerbower.
Bugs: AMBARI-4569
https://issues.apache.org/jira/browse/AMBARI-4569
Repository: ambari
Description
-------
* Added Helper class, no additional tests required for (it only separates a single method that is already exercised).
* Modified test case for logic added in HeartbeatHandler
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java ac284b3
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java cab12e9
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 0efc935
ambari-server/src/main/java/org/apache/ambari/server/controller/PassiveStateHelper.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java feb0469
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java bfc74b1
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java afec756
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java ff461f7
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 7106c01
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java 81c1daf
Diff: https://reviews.apache.org/r/17904/diff/
Testing
-------
Running org.apache.ambari.server.agent.TestHeartbeatHandler
Tests run: 23, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 31.918 sec
Running org.apache.ambari.server.controller.AmbariManagementControllerImplTest
Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.352 sec
Total
Results :
Tests run: 1397, Failures: 0, Errors: 0, Skipped: 7
Thanks,
Nate Cole
Re: Review Request 17904: Host health status should ignore host components
in Out-of-Service (passive) mode
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17904/#review34085
-----------------------------------------------------------
Ship it!
Ship It!
- Sid Wagle
On Feb. 10, 2014, 4:02 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17904/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2014, 4:02 p.m.)
>
>
> Review request for Ambari, Sid Wagle and Tom Beerbower.
>
>
> Bugs: AMBARI-4569
> https://issues.apache.org/jira/browse/AMBARI-4569
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Added Helper class, no additional tests required for (it only separates a single method that is already exercised).
> * Modified test case for logic added in HeartbeatHandler
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java ac284b3
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java cab12e9
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 0efc935
> ambari-server/src/main/java/org/apache/ambari/server/controller/PassiveStateHelper.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java feb0469
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java bfc74b1
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java afec756
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java ff461f7
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 7106c01
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java 81c1daf
>
> Diff: https://reviews.apache.org/r/17904/diff/
>
>
> Testing
> -------
>
> Running org.apache.ambari.server.agent.TestHeartbeatHandler
> Tests run: 23, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 31.918 sec
> Running org.apache.ambari.server.controller.AmbariManagementControllerImplTest
> Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.352 sec
>
>
> Total
> Results :
>
> Tests run: 1397, Failures: 0, Errors: 0, Skipped: 7
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 17904: Host health status should ignore host components
in Out-of-Service (passive) mode
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17904/#review34087
-----------------------------------------------------------
Ship it!
Ship It!
- Tom Beerbower
On Feb. 10, 2014, 4:02 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17904/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2014, 4:02 p.m.)
>
>
> Review request for Ambari, Sid Wagle and Tom Beerbower.
>
>
> Bugs: AMBARI-4569
> https://issues.apache.org/jira/browse/AMBARI-4569
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Added Helper class, no additional tests required for (it only separates a single method that is already exercised).
> * Modified test case for logic added in HeartbeatHandler
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java ac284b3
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java cab12e9
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 0efc935
> ambari-server/src/main/java/org/apache/ambari/server/controller/PassiveStateHelper.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java feb0469
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java bfc74b1
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java afec756
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java ff461f7
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 7106c01
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java 81c1daf
>
> Diff: https://reviews.apache.org/r/17904/diff/
>
>
> Testing
> -------
>
> Running org.apache.ambari.server.agent.TestHeartbeatHandler
> Tests run: 23, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 31.918 sec
> Running org.apache.ambari.server.controller.AmbariManagementControllerImplTest
> Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.352 sec
>
>
> Total
> Results :
>
> Tests run: 1397, Failures: 0, Errors: 0, Skipped: 7
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 17904: Host health status should ignore host components
in Out-of-Service (passive) mode
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17904/
-----------------------------------------------------------
(Updated Feb. 10, 2014, 11:02 a.m.)
Review request for Ambari, Sid Wagle and Tom Beerbower.
Bugs: AMBARI-4569
https://issues.apache.org/jira/browse/AMBARI-4569
Repository: ambari
Description
-------
* Added Helper class, no additional tests required for (it only separates a single method that is already exercised).
* Modified test case for logic added in HeartbeatHandler
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java ac284b3
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java cab12e9
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 0efc935
ambari-server/src/main/java/org/apache/ambari/server/controller/PassiveStateHelper.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java feb0469
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java bfc74b1
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java afec756
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java ff461f7
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 7106c01
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java 81c1daf
Diff: https://reviews.apache.org/r/17904/diff/
Testing
-------
Running org.apache.ambari.server.agent.TestHeartbeatHandler
Tests run: 23, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 31.918 sec
Running org.apache.ambari.server.controller.AmbariManagementControllerImplTest
Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.352 sec
Total
Results :
Tests run: 1397, Failures: 0, Errors: 0, Skipped: 7
Thanks,
Nate Cole