You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/05/23 09:49:08 UTC

[GitHub] [flink] godfreyhe opened a new pull request #8520: [FLINK-12600] [table-planner-blink] Introduce planner rules to do deterministic rewriting on RelNode

godfreyhe opened a new pull request #8520: [FLINK-12600] [table-planner-blink] Introduce planner rules to do deterministic rewriting on RelNode
URL: https://github.com/apache/flink/pull/8520
 
 
   
   ## What is the purpose of the change
   
   *Introduce planner rules to do deterministic rewriting on RelNode*
   
   
   ## Brief change log
   
     - * FlinkLimit0RemoveRule, that rewrites `limit 0` to empty Values*
     - *FlinkRewriteSubQueryRule, that rewrites a Filter with condition: `(select count from T) > 0` to a Filter with condition: `exists(select * from T)`, which could be converted to SEMI Join by FlinkSubQueryRemoveRule*
     - *ReplaceIntersectWithSemiJoinRule, that rewrites distinct Intersect to a distinct Aggregate on a SEMI Join*
     - *ReplaceMinusWithAntiJoinRule, that rewrites distinct Minus to a distinct Aggregate on an ANTI Join*
     - *introduce FlinkPruneEmptyRules#JOIN_RIGHT_INSTANCE to handle ANTI join with empty right*
   
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
     - *Added FlinkLimit0RemoveRuleTest that validates the logical plan result after FlinkLimit0RemoveRule is applied, and added Limit0RemoveITCase that validates the execution result*
     - *Added FlinkRewriteSubQueryRuleTest that validates the logical plan results after FlinkRewriteSubQueryRule is applied*
     - *Added ReplaceIntersectWithSemiJoinRuleTest that validates the logical plan results after ReplaceIntersectWithSemiJoinRule is applied*
     - *Added ReplaceMinusWithAntiJoinRuleTest that validates the logical plan results after ReplaceMinusWithAntiJoinRule is applied*
     - *Added FlinkPruneEmptyRulesTest that validates the logical plan results after FlinkPruneEmptyRules is applied*
     - *Added SetOperatorsTest that validates the physical plan results after ReplaceMinusWithAntiJoinRule and ReplaceIntersectWithSemiJoinRuleTest are applied*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services