You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Sergey Nuyanzin (Jira)" <ji...@apache.org> on 2023/06/20 13:16:00 UTC
[jira] [Resolved] (FLINK-24592) FlinkSQL multiline parser improvements
[ https://issues.apache.org/jira/browse/FLINK-24592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sergey Nuyanzin resolved FLINK-24592.
-------------------------------------
Resolution: Fixed
Merged to master as [c4b8cafe91220ec36defbe813baa5155b7466590|https://github.com/apache/flink/commit/c4b8cafe91220ec36defbe813baa5155b7466590]
Currently merged without continuation prompts.
For those there will be a separate tasks
> FlinkSQL multiline parser improvements
> --------------------------------------
>
> Key: FLINK-24592
> URL: https://issues.apache.org/jira/browse/FLINK-24592
> Project: Flink
> Issue Type: Sub-task
> Components: Table SQL / Client
> Reporter: Sergey Nuyanzin
> Assignee: Sergey Nuyanzin
> Priority: Major
> Labels: pull-request-available, stale-assigned
>
> Currently existing multiline parser has limitations e.g.
> line could not end with semicolon e.g. as a part of field value, comment or column name.
> Also if a query contains '--' e.g. as a part of varchar field value then it fails.
> In case there is no objections I would put some efforts to improve this behavior;
> here it is a list of sample problem queries
> {code:sql}
> select 123; -- comment
> select 1 as `1--`;
> select '--';
> -- This query works if a user copy-pastes it to FlinkSQL, however it fails if a user types it in FlinkSQL
> select '1;
> ';
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)