[GitHub] [helix] xyuanlu commented on a change in pull request #1565: Refine task framework log

[GitBox <gi...@apache.org>]

xyuanlu commented on a change in pull request #1565:
URL: https://github.com/apache/helix/pull/1565#discussion_r533749132



##########
File path: helix-core/src/main/java/org/apache/helix/task/TaskDriver.java
##########
@@ -804,7 +803,9 @@ private void validateConfigsForTaskModifications(String workflowName, String job
     }
 
     if ((taskConfig.getCommand() == null) == (jobConfig.getCommand() == null)) {
-      throw new HelixException("Command must exist in either job or task, not both!");
+      throw new HelixException(String
+          .format("Command must exist in either job %s or task %s, not both!", jobName,
+              taskConfig.getId()));

Review comment:
       TFTR. Updated.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org