You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/04/08 17:29:05 UTC

[GitHub] [hbase] saintstack commented on a change in pull request #3117: HBASE-25709 Close region may stuck when region is compacting and skip…

saintstack commented on a change in pull request #3117:
URL: https://github.com/apache/hbase/pull/3117#discussion_r609933360



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ScannerContext.java
##########
@@ -110,7 +110,13 @@
    */
   final ServerSideScanMetrics metrics;
 
-  ScannerContext(boolean keepProgress, LimitFields limitsToCopy, boolean trackMetrics) {
+  /**
+   * Set this to true will prevent the looping skip of heap cells, see HBASE-25709.

Review comment:
       I read this PR first w/o looking at the JIRA. I did not understand why I would want to avoid 'looping skip of heap cells' after reading comments like this. I'd suggest say more here in the code on what this flag does? Thanks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org