You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by clebertsuconic <gi...@git.apache.org> on 2015/06/04 03:42:13 UTC
[GitHub] activemq-artemis pull request: Connection Factory updates
GitHub user clebertsuconic opened a pull request:
https://github.com/apache/activemq-artemis/pull/15
Connection Factory updates
This is a dependency for me on the examples work
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/clebertsuconic/activemq-artemis connectionFactory
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/15.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #15
----
commit 66838f8d8e661c34518dcd14d963d31cc7c34f1d
Author: Clebert Suconic <cl...@apache.org>
Date: 2015-06-03T13:22:51Z
https://issues.apache.org/jira/browse/ARTEMIS-130 connection-factory constructors
This will make examples easier to understand, less stuff to be written before instantiating connection factories
commit 919bd07364aed9f3ae47f1b15dbed16c6fc3cc1a
Author: Clebert Suconic <cl...@apache.org>
Date: 2015-06-03T23:05:24Z
https://issues.apache.org/jira/browse/ARTEMIS-118 - update activemq client
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Connection Factory updates
Posted by johnament <gi...@git.apache.org>.
Github user johnament commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/15#discussion_r31688005
--- Diff: tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/ConnectionTest.java ---
@@ -65,6 +67,33 @@ public void testManyConnections() throws Exception
//
@Test
+ public void testThroughNewConnectionFactory() throws Exception
+ {
+ testThroughNewConnectionFactory(new ActiveMQConnectionFactory());
+ testThroughNewConnectionFactory(new ActiveMQConnectionFactory("tcp://localhost:61616"));
+ testThroughNewConnectionFactory(new ActiveMQConnectionFactory("tcp://localhost:61616", "guest", "guest"));
+ }
+
+ private void testThroughNewConnectionFactory(ActiveMQConnectionFactory factory) throws Exception
+ {
+ Connection conn = factory.createConnection();
+ conn.close();
+
+ try (JMSContext ctx = factory.createContext())
+ {
+ ctx.createProducer().send(ctx.createQueue("queue"),"Test");
+ }
+
+ try (JMSContext ctx = factory.createContext())
+ {
+ Assert.assertNotNull(ctx.createConsumer(ctx.createQueue("queue")).receiveNoWait());
+ Assert.assertNull(ctx.createConsumer(ctx.createQueue("queue")).receiveNoWait());
+ }
+
+ factory.close();
--- End diff --
Seems like it would be a good idea for the connection factory to be auto closeable even if the spec doesn't say so.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Connection Factory updates
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/15#discussion_r31691246
--- Diff: tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/ConnectionTest.java ---
@@ -65,6 +67,33 @@ public void testManyConnections() throws Exception
//
@Test
+ public void testThroughNewConnectionFactory() throws Exception
+ {
+ testThroughNewConnectionFactory(new ActiveMQConnectionFactory());
+ testThroughNewConnectionFactory(new ActiveMQConnectionFactory("tcp://localhost:61616"));
+ testThroughNewConnectionFactory(new ActiveMQConnectionFactory("tcp://localhost:61616", "guest", "guest"));
+ }
+
+ private void testThroughNewConnectionFactory(ActiveMQConnectionFactory factory) throws Exception
+ {
+ Connection conn = factory.createConnection();
+ conn.close();
+
+ try (JMSContext ctx = factory.createContext())
+ {
+ ctx.createProducer().send(ctx.createQueue("queue"),"Test");
+ }
+
+ try (JMSContext ctx = factory.createContext())
+ {
+ Assert.assertNotNull(ctx.createConsumer(ctx.createQueue("queue")).receiveNoWait());
+ Assert.assertNull(ctx.createConsumer(ctx.createQueue("queue")).receiveNoWait());
+ }
+
+ factory.close();
--- End diff --
good idea!!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Connection Factory updates
Posted by johnament <gi...@git.apache.org>.
Github user johnament commented on the pull request:
https://github.com/apache/activemq-artemis/pull/15#issuecomment-108931776
@clebertsuconic I'm not sure what you're referring to btw, I don't recall discussing with you that option.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Connection Factory updates
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/15#issuecomment-108713131
I will need to update this PR. I used the wrong super class for the tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Connection Factory updates
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/15#discussion_r31731039
--- Diff: pom.xml ---
@@ -53,7 +53,7 @@
<properties>
<!-- base url for site deployment. See distribution management for full url. Override this in settings.xml for staging -->
<staging.siteURL>scp://people.apache.org/x1/www/activemq.apache.org</staging.siteURL>
- <netty.version>4.0.28.Final</netty.version>
+ <netty.version>4.0.20.Final</netty.version>
--- End diff --
the conversation I was referring was the --allow-anonymous Y, I'm adding an option for N now
The downgrade.. I'm not sure I will merge it yet.. I'm trying to figure out why netty update broke the server.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Connection Factory updates
Posted by johnament <gi...@git.apache.org>.
Github user johnament commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/15#discussion_r31742948
--- Diff: pom.xml ---
@@ -53,7 +53,7 @@
<properties>
<!-- base url for site deployment. See distribution management for full url. Override this in settings.xml for staging -->
<staging.siteURL>scp://people.apache.org/x1/www/activemq.apache.org</staging.siteURL>
- <netty.version>4.0.28.Final</netty.version>
+ <netty.version>4.0.20.Final</netty.version>
--- End diff --
Ok, I see the error. i can poke around it some more if you want to downgrade.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Connection Factory updates
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/15
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Connection Factory updates
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/15#issuecomment-108997136
@johnament I will downgrade for now, so just so the pr checks won't freeze as they are freezing now.
I will do some debug on today.. I will keep you posted.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Connection Factory updates
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/15#issuecomment-108919732
@johnament FYI: I added 8edcf7c5b214b44ed81dd78eb8caccb04e104310 based on our conversation
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Connection Factory updates
Posted by johnament <gi...@git.apache.org>.
Github user johnament commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/15#discussion_r31731232
--- Diff: pom.xml ---
@@ -53,7 +53,7 @@
<properties>
<!-- base url for site deployment. See distribution management for full url. Override this in settings.xml for staging -->
<staging.siteURL>scp://people.apache.org/x1/www/activemq.apache.org</staging.siteURL>
- <netty.version>4.0.28.Final</netty.version>
+ <netty.version>4.0.20.Final</netty.version>
--- End diff --
That's kind of scary. No automation around the network based connectors?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Connection Factory updates
Posted by johnament <gi...@git.apache.org>.
Github user johnament commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/15#discussion_r31730205
--- Diff: pom.xml ---
@@ -53,7 +53,7 @@
<properties>
<!-- base url for site deployment. See distribution management for full url. Override this in settings.xml for staging -->
<staging.siteURL>scp://people.apache.org/x1/www/activemq.apache.org</staging.siteURL>
- <netty.version>4.0.28.Final</netty.version>
+ <netty.version>4.0.20.Final</netty.version>
--- End diff --
Downgrading?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Connection Factory updates
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/15#discussion_r31732804
--- Diff: pom.xml ---
@@ -53,7 +53,7 @@
<properties>
<!-- base url for site deployment. See distribution management for full url. Override this in settings.xml for staging -->
<staging.siteURL>scp://people.apache.org/x1/www/activemq.apache.org</staging.siteURL>
- <netty.version>4.0.28.Final</netty.version>
+ <netty.version>4.0.20.Final</netty.version>
--- End diff --
I screwed up on not having waited the PR tests to finish.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---