You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/01/12 05:43:29 UTC
[GitHub] [iotdb] CloudWise-Lukemiao opened a new pull request #4783: [IOTDB-2310] grafana plugin NPE, Using aggregate queries with "group …
CloudWise-Lukemiao opened a new pull request #4783:
URL: https://github.com/apache/iotdb/pull/4783
[IOTDB-2310] grafana plugin NPE, Using aggregate queries with "group by level=*"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou closed pull request #4783: [IOTDB-2283][IOTDB-2310][IOTDB-2311][IOTDB-2372][IOTDB-2313][IOTDB-2362] REST: metadata query interface
Posted by GitBox <gi...@apache.org>.
HTHou closed pull request #4783:
URL: https://github.com/apache/iotdb/pull/4783
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4783: [IOTDB-2283][IOTDB-2310][IOTDB-2311][IOTDB-2372] REST: metadata query interface
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4783:
URL: https://github.com/apache/iotdb/pull/4783#issuecomment-1010696083
[](https://coveralls.io/builds/45623700)
Coverage increased (+0.04%) to 68.074% when pulling **18373ea048d58e3c539b7ed786053ee1068858f9 on CloudWise-Lukemiao:iotdb-2310** into **ab24ce00856605d3bdffcb3b5eb89d1adafa19a4 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4783: [IOTDB-2310] grafana plugin NPE, Using aggregate queries with "group …
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4783:
URL: https://github.com/apache/iotdb/pull/4783#issuecomment-1010696083
[](https://coveralls.io/builds/45556936)
Coverage increased (+0.02%) to 67.655% when pulling **93121aba30703370f9b23e0f3f3ea1bb6751fc6a on CloudWise-Lukemiao:iotdb-2310** into **c5283320ee3521ed0d4f85cad072ef370a7bf8b4 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls commented on pull request #4783: [IOTDB-2310] grafana plugin NPE, Using aggregate queries with "group …
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #4783:
URL: https://github.com/apache/iotdb/pull/4783#issuecomment-1010696083
[](https://coveralls.io/builds/45555907)
Coverage increased (+0.009%) to 67.649% when pulling **8ad088831057d7bba33d3a060ce0b7121e691cc9 on CloudWise-Lukemiao:iotdb-2310** into **c5283320ee3521ed0d4f85cad072ef370a7bf8b4 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu commented on a change in pull request #4783: [IOTDB-2283][IOTDB-2310][IOTDB-2311][IOTDB-2372][IOTDB-2313][IOTDB-2362] GC overhead limit and REST: metadata query interface
Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on a change in pull request #4783:
URL: https://github.com/apache/iotdb/pull/4783#discussion_r784892040
##########
File path: server/src/main/java/org/apache/iotdb/db/protocol/rest/handler/RequestValidationHandler.java
##########
@@ -29,6 +29,9 @@ private RequestValidationHandler() {}
public static void validateSQL(SQL sql) {
Objects.requireNonNull(sql.getSql(), "sql should not be null");
+ if (sql.getRowLimit() != null && sql.getRowLimit() <= 0) {
+ Objects.requireNonNull(null, "rowLimit should be greater than or equal to 0");
Review comment:
There are many ways to throw a validation error as a RuntimeException.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4783: [IOTDB-2310][IOTDB-2283][IOTDB-2372][IOTDB-2362] grafana plugin NPE, Using aggregate queries with "group …
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4783:
URL: https://github.com/apache/iotdb/pull/4783#issuecomment-1010696083
[](https://coveralls.io/builds/45607790)
Coverage increased (+0.01%) to 68.044% when pulling **24b85d0f6526109d96ff2f81451d5d58bbfba225 on CloudWise-Lukemiao:iotdb-2310** into **ab24ce00856605d3bdffcb3b5eb89d1adafa19a4 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4783: [IOTDB-2310][IOTDB-2283][IOTDB-2372][IOTDB-2362] grafana plugin NPE, Using aggregate queries with "group …
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4783:
URL: https://github.com/apache/iotdb/pull/4783#issuecomment-1010696083
[](https://coveralls.io/builds/45608716)
Coverage increased (+0.004%) to 68.034% when pulling **24b85d0f6526109d96ff2f81451d5d58bbfba225 on CloudWise-Lukemiao:iotdb-2310** into **ab24ce00856605d3bdffcb3b5eb89d1adafa19a4 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4783: [IOTDB-2283][IOTDB-2310][IOTDB-2311][IOTDB-2372] REST: metadata query interface
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4783:
URL: https://github.com/apache/iotdb/pull/4783#issuecomment-1010696083
[](https://coveralls.io/builds/45622555)
Coverage decreased (-0.009%) to 68.02% when pulling **24b85d0f6526109d96ff2f81451d5d58bbfba225 on CloudWise-Lukemiao:iotdb-2310** into **ab24ce00856605d3bdffcb3b5eb89d1adafa19a4 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org