You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/09/22 06:18:18 UTC
[GitHub] [iotdb] jamber001 opened a new pull request #4009: [IOTDB-1719] client-cpp should firstly use thrift head files in thrif…
jamber001 opened a new pull request #4009:
URL: https://github.com/apache/iotdb/pull/4009
https://issues.apache.org/jira/projects/IOTDB/issues/IOTDB-1719
client-cpp/src/main/CMakeLists.txt:39
==================================
Add Boost include path for MacOS
INCLUDE_DIRECTORIES(/usr/local/include)
Add Thrift include directory
INCLUDE_DIRECTORIES(${TOOLS_DIR}/thrift/target/thrift-0.14.1/lib/cpp/src)
======================================
If local machine has installed other version's thrift,
this CMakeLists.txt will cause that compiling client-cpp use thrift head files in not compile-tools/thrift/target/thrift-0.14.1/lib/cpp/src/ but /usr/local/include.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu merged pull request #4009: [IOTDB-1719] client-cpp should firstly use thrift head files in thrif…
Posted by GitBox <gi...@apache.org>.
SteveYurongSu merged pull request #4009:
URL: https://github.com/apache/iotdb/pull/4009
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls commented on pull request #4009: [IOTDB-1719] client-cpp should firstly use thrift head files in thrif…
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #4009:
URL: https://github.com/apache/iotdb/pull/4009#issuecomment-924645104
[](https://coveralls.io/builds/42986344)
Coverage increased (+0.01%) to 67.444% when pulling **ffe24ec9a2e90f6409f52b9b26d70c1c609495b4 on jamber001:IOTDB-1719** into **c75a71f76c10a3f79b905df3daeef5429704a7f7 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jamber001 commented on pull request #4009: [IOTDB-1719] client-cpp should firstly use thrift head files in thrif…
Posted by GitBox <gi...@apache.org>.
jamber001 commented on pull request #4009:
URL: https://github.com/apache/iotdb/pull/4009#issuecomment-926280476
@HTHou Is this PR OK to be merged ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jamber001 closed pull request #4009: [IOTDB-1719] client-cpp should firstly use thrift head files in thrif…
Posted by GitBox <gi...@apache.org>.
jamber001 closed pull request #4009:
URL: https://github.com/apache/iotdb/pull/4009
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4009: [IOTDB-1719] client-cpp should firstly use thrift head files in thrif…
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4009:
URL: https://github.com/apache/iotdb/pull/4009#issuecomment-924645104
[](https://coveralls.io/builds/42986406)
Coverage increased (+0.03%) to 67.459% when pulling **ffe24ec9a2e90f6409f52b9b26d70c1c609495b4 on jamber001:IOTDB-1719** into **c75a71f76c10a3f79b905df3daeef5429704a7f7 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org