You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Xingcan Cui (Jira)" <ji...@apache.org> on 2020/08/14 02:57:00 UTC
[jira] [Comment Edited] (FLINK-7865) Remove predicate restrictions
on TableFunction left outer join
[ https://issues.apache.org/jira/browse/FLINK-7865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177438#comment-17177438 ]
Xingcan Cui edited comment on FLINK-7865 at 8/14/20, 2:56 AM:
--------------------------------------------------------------
Hi [~godfreyhe], it took me some time to think about how to do the reversion. However, the codebase has changed too much and I'm afraid I don't have much bandwidth in recent days to continue working on this (just onboarded a new company). I was wondering if you could take it over. Thanks!
Some inspections that may help (hopefully):
In {{FlinkDecorrelateProgram.optimize()}}, {{RelDecorrelator.decorrelateQuery(root)}} will rewrite the {{LogicalCorrelate}} of a left lateral join plan with extra conditions to {{LogicalJoin}}. For left lateral join without extra conditions, it will preserve the {{LogicalCorrelate}}.
was (Author: xccui):
Hi [~godfreyhe], it took me some time to think about how to do the reversion. However, the codebase has changed too much and I'm afraid I don't have much bandwidth in recent days to continue working on this. I was wondering if you could take it over. Thanks!
Some inspections that may help (hopefully):
In {{FlinkDecorrelateProgram.optimize()}}, {{RelDecorrelator.decorrelateQuery(root)}} will rewrite the {{LogicalCorrelate}} of a left lateral join plan with extra conditions to {{LogicalJoin}}. For left lateral join without extra conditions, it will preserve the {{LogicalCorrelate}}.
> Remove predicate restrictions on TableFunction left outer join
> --------------------------------------------------------------
>
> Key: FLINK-7865
> URL: https://issues.apache.org/jira/browse/FLINK-7865
> Project: Flink
> Issue Type: New Feature
> Components: Table SQL / API
> Reporter: Xingcan Cui
> Priority: Major
>
> To cover up the improper translation of lateral table left outer join (CALCITE-2004), we have temporarily forbidden the predicates (except {{true}} literal) in Table API (FLINK-7853) and SQL (FLINK-7854). Once the issue has been fixed in Calcite, we should remove the restrictions. The tasks may include removing Table API/SQL condition check, removing validation tests, enabling integration tests, updating the documents, etc.
> See [this thread on Calcite dev list|https://lists.apache.org/thread.html/16caeb8b1649c4da85f9915ea723c6c5b3ced0b96914cadc24ee4e15@%3Cdev.calcite.apache.org%3E] for more information.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)