[GitHub] [spark] MaxGekk commented on a change in pull request #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

[GitBox <gi...@apache.org>]

MaxGekk commented on a change in pull request #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#discussion_r386562324
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/csvExpressions.scala
 ##########
 @@ -93,8 +98,6 @@ case class CsvToStructs(
     }
   }
 
-  val nameOfCorruptRecord = SQLConf.get.getConf(SQLConf.COLUMN_NAME_OF_CORRUPT_RECORD)
 
 Review comment:
   Reading of the config can be moved into `parser` initialization. In that case, it will not influence on planning.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org