You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/11/07 22:35:16 UTC
[kudu-CR] Workaround KUDU-1580: bump negotiation timeout to 15sec
Hello Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4977
to review the following change.
Change subject: Workaround KUDU-1580: bump negotiation timeout to 15sec
......................................................................
Workaround KUDU-1580: bump negotiation timeout to 15sec
KUDU-1580 is a bug where RPC negotiation timeouts aren't considered
retriable errors. We see this cause issues on test clusters
occasionally.
Because fixing the bug is a bit trickier, let's bump the timeout for
1.1, and then drop it back down once the bug is addressed.
Change-Id: I98b246639882b2ea107648562a383f6b40b35390
---
M src/kudu/rpc/reactor.cc
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/4977/1
--
To view, visit http://gerrit.cloudera.org:8080/4977
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I98b246639882b2ea107648562a383f6b40b35390
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR] Workaround KUDU-1580: bump negotiation timeout to 15sec
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Workaround KUDU-1580: bump negotiation timeout to 15sec
......................................................................
Patch Set 1: Code-Review+2
This doesn't mean all "the other end is down and has been down for a while" style connection errors now take 15s instead of 3s, right?
--
To view, visit http://gerrit.cloudera.org:8080/4977
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I98b246639882b2ea107648562a383f6b40b35390
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Workaround KUDU-1580: bump negotiation timeout to 15sec
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: Workaround KUDU-1580: bump negotiation timeout to 15sec
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4977
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I98b246639882b2ea107648562a383f6b40b35390
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Workaround KUDU-1580: bump negotiation timeout to 15sec
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Workaround KUDU-1580: bump negotiation timeout to 15sec
......................................................................
Patch Set 1:
yea, it would make it take longer if it's down and not responding with 'connection refused' (eg the whole machine is down). Also would make it longer if it's up but frozen.
So, it's not a great longer term workaround, but given that we seem to have false positive errors here, I think this is preferable to doing nothing.
--
To view, visit http://gerrit.cloudera.org:8080/4977
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I98b246639882b2ea107648562a383f6b40b35390
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Workaround KUDU-1580: bump negotiation timeout to 15sec
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: Workaround KUDU-1580: bump negotiation timeout to 15sec
......................................................................
Workaround KUDU-1580: bump negotiation timeout to 15sec
KUDU-1580 is a bug where RPC negotiation timeouts aren't considered
retriable errors. We see this cause issues on test clusters
occasionally.
Because fixing the bug is a bit trickier, let's bump the timeout for
1.1, and then drop it back down once the bug is addressed.
Change-Id: I98b246639882b2ea107648562a383f6b40b35390
Reviewed-on: http://gerrit.cloudera.org:8080/4977
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/rpc/reactor.cc
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Adar Dembo: Looks good to me, approved
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4977
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I98b246639882b2ea107648562a383f6b40b35390
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>