[jira] [Commented] (BEAM-474) Tests which evaluate DisplayData but don't run a pipeline should be marked @NeedsRunner not @RunnableOnService

["Scott Wegner (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394011#comment-15394011 ] 

Scott Wegner commented on BEAM-474:
-----------------------------------

My understanding when we wrote the tests was different. I thought the distinction was:

* @NeedsRunner tests require some runner to execute, and will default to DirectRunner
* @RunnableOnService tests form a validation suite that runners are implemented correctly, and should be run on all runners

If my interpretation was incorrect (and it sounds like it was), then we should fix the tests. I just want to make sure that they will still be executed against all runners.

> Tests which evaluate DisplayData but don't run a pipeline should be marked @NeedsRunner not @RunnableOnService
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: BEAM-474
>                 URL: https://issues.apache.org/jira/browse/BEAM-474
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Luke Cwik
>            Priority: Minor
>
> Tests which evaluate DisplayData but don't run a pipeline should be marked @NeedsRunner not @RunnableOnService
> @RunnableOnService represents tests which actually execute a Pipeline while @NeedsRunner represents tests that need a runner to construct the pipeline.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)