You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Haohui Mai (JIRA)" <ji...@apache.org> on 2016/03/26 00:06:25 UTC
[jira] [Commented] (HDFS-8101) DFSClient use of non-constant
DFSConfigKeys pulls in WebHDFS classes at runtime
[ https://issues.apache.org/jira/browse/HDFS-8101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15212558#comment-15212558 ]
Haohui Mai commented on HDFS-8101:
----------------------------------
Backporting this patch to branch-2.7.
Before this patch, loading {{DFSConfigKeys}} also transitively loads {{javax.servlet.Filter}}. Applications depend on {{hadoop-client}} will fail as {{hadoop-client}} excludes {{javax.servlet.servlet-api}} from its dependency, resulting in {{ClassNotFoundError}}.
> DFSClient use of non-constant DFSConfigKeys pulls in WebHDFS classes at runtime
> -------------------------------------------------------------------------------
>
> Key: HDFS-8101
> URL: https://issues.apache.org/jira/browse/HDFS-8101
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs-client
> Affects Versions: 2.7.0
> Reporter: Sean Busbey
> Assignee: Sean Busbey
> Priority: Minor
> Fix For: 2.8.0
>
> Attachments: HDFS-8101.1.patch.txt
>
>
> Previously, all references to DFSConfigKeys in DFSClient were compile time constants which meant that normal users of DFSClient wouldn't resolve DFSConfigKeys at run time. As of HDFS-7718, DFSClient has a reference to a member of DFSConfigKeys that isn't compile time constant (DFS_CLIENT_KEY_PROVIDER_CACHE_EXPIRY_DEFAULT).
> Since the class must be resolved now, this particular member
> {code}
> public static final String DFS_WEBHDFS_AUTHENTICATION_FILTER_DEFAULT = AuthFilter.class.getName();
> {code}
> means that javax.servlet.Filter needs to be on the classpath.
> javax-servlet-api is one of the properly listed dependencies for HDFS, however if we replace {{AuthFilter.class.getName()}} with the equivalent String literal then downstream folks can avoid including it while maintaining compatibility.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)