You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by sp...@apache.org on 2015/11/23 17:34:19 UTC
[1/2] incubator-tinkerpop git commit: Fixed feature check in
shouldPersistDataOnClose()
Repository: incubator-tinkerpop
Updated Branches:
refs/heads/master d53129888 -> e946d6990
Fixed feature check in shouldPersistDataOnClose()
GraphTests.shouldPersistDataOnClose checked that *edges* supported String type properties before adding String type properties to *vertices*. Changed this check to be consistent with the operation being performed.
Additional Notes:
1) This unit test adds properties to vertices, but does not *explicitly* make the check for Graph.Features.VertexFeatures.FEATURE_ADD_PROPERTY support in its feature requirements. The feature requirement set SIMPLE does not include Graph.Features.VertexFeatures.FEATURE_ADD_PROPERTY, but rather includes the feature Graph.Features.VertexPropertyFeatures.FEATURE_ADD_PROPERTY, which is a check for being able to add meta properties. Therefore, since meta properties cannot be supported without basic add property support for vertices, the check for adding properties to vertices is *implicit*, not explicit.
2) Although Graph.Features.VertexPropertyFeatures.FEATURE_ADD_PROPERTY is included in the feature set requirements for this unit test, this unit test does not actually depend on meta property support. This unit test will not run for graphs that support persistence, but do not support meta properties.
Project: http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/commit/d828252f
Tree: http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/tree/d828252f
Diff: http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/diff/d828252f
Branch: refs/heads/master
Commit: d828252fa3f13523469d5932802b99f856a6fc79
Parents: 4a995c2
Author: Jonathan Ellithorpe <jd...@cs.stanford.edu>
Authored: Sat Nov 21 12:15:37 2015 -0800
Committer: Jonathan Ellithorpe <jd...@cs.stanford.edu>
Committed: Sat Nov 21 12:15:37 2015 -0800
----------------------------------------------------------------------
.../java/org/apache/tinkerpop/gremlin/structure/GraphTest.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/blob/d828252f/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/structure/GraphTest.java
----------------------------------------------------------------------
diff --git a/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/structure/GraphTest.java b/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/structure/GraphTest.java
index 255809e..09d836a 100644
--- a/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/structure/GraphTest.java
+++ b/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/structure/GraphTest.java
@@ -1205,7 +1205,7 @@ public class GraphTest extends AbstractGremlinTest {
final Vertex v = graph.addVertex();
final Vertex u = graph.addVertex();
- if (graph.features().edge().properties().supportsStringValues()) {
+ if (graph.features().vertex().properties().supportsStringValues()) {
v.property(VertexProperty.Cardinality.single, "name", "marko");
u.property(VertexProperty.Cardinality.single, "name", "pavel");
}
[2/2] incubator-tinkerpop git commit: Merge branch 'patch-1' of
https://github.com/ellitron/incubator-tinkerpop
Posted by sp...@apache.org.
Merge branch 'patch-1' of https://github.com/ellitron/incubator-tinkerpop
Project: http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/commit/e946d699
Tree: http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/tree/e946d699
Diff: http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/diff/e946d699
Branch: refs/heads/master
Commit: e946d69900c66389775a3a7096263a3725d2176c
Parents: d531298 d828252
Author: Stephen Mallette <sp...@genoprime.com>
Authored: Mon Nov 23 11:17:10 2015 -0500
Committer: Stephen Mallette <sp...@genoprime.com>
Committed: Mon Nov 23 11:17:10 2015 -0500
----------------------------------------------------------------------
.../java/org/apache/tinkerpop/gremlin/structure/GraphTest.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------