[GitHub] GabrielBrascher commented on a change in pull request #2660: Macaddresses

[GitBox <gi...@apache.org>]

GabrielBrascher commented on a change in pull request #2660: Macaddresses
URL: https://github.com/apache/cloudstack/pull/2660#discussion_r233235122
 
 

 ##########
 File path: utils/src/main/java/com/cloud/utils/net/MacAddress.java
 ##########
 @@ -31,9 +31,9 @@
 
 import org.apache.log4j.Logger;
 
-import com.cloud.utils.NumbersUtil;
-
 /**
+ * This class retrieves the (first) MAC address for the machine is it is loaded on and stores it statically for retrieval.
+ * It can also be used for formatting MAC addresses.
  * copied from the public domain utility from John Burkard.
  * @author <a href="mailto:jb@eaio.com">Johann Burkard</a>
 
 Review comment:
   When I see a piece of code like this I always ask myself if we should keep or delete authors references. What do you think of removing it?
   In my humble opinion, we should clean lines such as this `@author`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services