You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/11/16 18:48:49 UTC
[GitHub] [ozone] prashantpogde commented on a diff in pull request #3885: HDDS-7410. Ozone snapshot diff skeleton code.
prashantpogde commented on code in PR #3885:
URL: https://github.com/apache/ozone/pull/3885#discussion_r1024386577
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotManager.java:
##########
@@ -217,4 +224,40 @@ public static boolean isSnapshotKey(String[] keyParts) {
return (keyParts.length > 1) &&
(keyParts[0].compareTo(OM_SNAPSHOT_INDICATOR) == 0);
}
+
+ public SnapshotDiffReport getSnapshotDiffReport(final String volume,
+ final String bucket,
+ final String fromSnapshot,
+ final String toSnapshot)
+ throws IOException {
+ // Validate fromSnapshot and toSnapshot
+ final SnapshotInfo fsInfo = getSnapshotInfo(volume, bucket, fromSnapshot);
+ final SnapshotInfo tsInfo = getSnapshotInfo(volume, bucket, toSnapshot);
Review Comment:
There is no concept of snapdiff against active file system. We can do diff between only two stable(non-changing) images.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org