[GitHub] [apisix-docker] tokers commented on a change in pull request #124: fix: compile error with openssl

[GitBox <gi...@apache.org>]

tokers commented on a change in pull request #124:
URL: https://github.com/apache/apisix-docker/pull/124#discussion_r567825806



##########
File path: alpine-dev/Dockerfile
##########
@@ -5,13 +5,15 @@ FROM openresty/openresty:alpine-fat AS production-stage
 ARG ENABLE_PROXY
 RUN set -x \
     && (test "${ENABLE_PROXY}" != "true" || /bin/sed -i 's,http://dl-cdn.alpinelinux.org,https://mirrors.aliyun.com,g' /etc/apk/repositories) \
-    && apk add --no-cache --virtual .builddeps \
+    && apk add --no-cache --virtual .builddeps openssl-dev \

Review comment:
       It should be `openresty-openssl-dev`.

##########
File path: alpine/Dockerfile
##########
@@ -8,13 +8,15 @@ LABEL apisix_version="${APISIX_VERSION}"
 ARG ENABLE_PROXY
 RUN set -x \
     && (test "${ENABLE_PROXY}" != "true" || /bin/sed -i 's,http://dl-cdn.alpinelinux.org,https://mirrors.aliyun.com,g' /etc/apk/repositories) \
-    && apk add --no-cache --virtual .builddeps \
+    && apk add --no-cache --virtual .builddeps openssl-dev \

Review comment:
       Ditto.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org