You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@geode.apache.org by jb...@apache.org on 2018/10/10 16:59:47 UTC

[geode-native] 03/03: GEODE-5839: Fixes explicit constructor definition.

This is an automated email from the ASF dual-hosted git repository.

jbarrett pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/geode-native.git

commit cdcb703ed46e06318a074c90f137842c739ef5ae
Author: Jacob Barrett <jb...@pivotal.io>
AuthorDate: Tue Oct 9 13:34:07 2018 -0700

    GEODE-5839: Fixes explicit constructor definition.
    
    * Cleanup .clang-tidy files.
---
 .clang-tidy                                                   | 2 +-
 cppcache/include/geode/internal/CacheableBuiltinTemplates.hpp | 2 +-
 cppcache/integration-test-2/framework/.clang-tidy             | 6 ++++--
 3 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/.clang-tidy b/.clang-tidy
index 0968e48..6d39ded 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -1,6 +1,6 @@
 ---
 Checks:          '-*,clang-diagnostic-*,clang-analyzer-*,-clang-analyzer-alpha*,google-*,-google-readability-todo,-google-runtime-references,-google-default-arguments,-clang-analyzer-core.uninitialized.UndefReturn,-clang-analyzer-core.UndefinedBinaryOperatorResult,-clang-analyzer-optin.cplusplus.VirtualCall'
-WarningsAsErrors: 'clang-analyzer-optin.performance.*,clang-analyzer-core.*,clang-analyzer-unix.*,clang-diagnostic-*,google-*,clang-analyzer-cplusplus.*,clang-analyzer-security.insecureAPI.*,clang-analyzer-deadcode.*'
+WarningsAsErrors: '*'
 HeaderFilterRegex: '.*'
 FormatStyle:     file
 ...
diff --git a/cppcache/include/geode/internal/CacheableBuiltinTemplates.hpp b/cppcache/include/geode/internal/CacheableBuiltinTemplates.hpp
index 792687d..fb50a9f 100644
--- a/cppcache/include/geode/internal/CacheableBuiltinTemplates.hpp
+++ b/cppcache/include/geode/internal/CacheableBuiltinTemplates.hpp
@@ -120,7 +120,7 @@ class APACHE_GEODE_EXPORT CacheableArrayPrimitive
   inline CacheableArrayPrimitive() = default;
 
   template <typename TT>
-  CacheableArrayPrimitive(TT&& value) : m_value(std::forward<TT>(value)) {}
+  explicit CacheableArrayPrimitive(TT&& value) : m_value(std::forward<TT>(value)) {}
 
   ~CacheableArrayPrimitive() noexcept override = default;
 
diff --git a/cppcache/integration-test-2/framework/.clang-tidy b/cppcache/integration-test-2/framework/.clang-tidy
index 07eb839..1c4ed27 100644
--- a/cppcache/integration-test-2/framework/.clang-tidy
+++ b/cppcache/integration-test-2/framework/.clang-tidy
@@ -1,12 +1,14 @@
 ---
-Checks:          '-*,clang-diagnostic-*,clang-analyzer-*,-clang-analyzer-alpha*,google-*,-google-readability-todo,-google-runtime-references,-clang-analyzer-unix.cstring.NullArg'
-WarningsAsErrors: '*,-google-default-arguments'
+Checks:          '-*,clang-diagnostic-*,clang-analyzer-*,-clang-analyzer-alpha*,google-*,-google-readability-todo,-google-runtime-references,-google-default-arguments,-clang-analyzer-unix.cstring.NullArg'
+WarningsAsErrors: '*'
 HeaderFilterRegex: '.*'
 FormatStyle:     file
+...
 
 # Disable Checks
 # google-runtime-references - We have diverged from this rule due to both legacy and disagreement with the rule.
 # google-readability-todo - Adds current user name when fix applied.
 
 # TODO - Fix these checks
+# google-default-arguments
 # clang-analyzer-unix.cstring.NullArg - Generates errors in Boost, how do we ignore?