[GitHub] [geode] PurelyApplied opened pull request #3038: GEODE-6237: Opt into publication rather than opting out.

["PurelyApplied (GitHub)" <gi...@apache.org>]

* Remove 'disableMavenPublishing' declaration and use.  Add some todos for the time being.
* Remove unused publication block that was otherwise disabled in :extensions:geode-modules-assembly.
* Flatten if/else:'if/else:"if/else:"' logic in publish.gradle
* Move askpass block to rootProject build.gradle

-----

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/3038 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] PurelyApplied commented on issue #3038: GEODE-6237: Opt into publication rather than opting out.

["PurelyApplied (GitHub)" <gi...@apache.org>]

This PR does nothing to address GEODE-6208 or the issue with sourceJar / javadocJar (is there a JIRA for that..?), but it is a work-in-progress I had to clean up publication in general.

If any work is done on either of these issues while I'm away, I would greatly appreciate it to stem from this cleanup rather than perpetuate the very invasive, non-modular way we configure publication at present.

[ Full content available at: https://github.com/apache/geode/pull/3038 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] PurelyApplied commented on pull request #3038: GEODE-6237: Opt into publication rather than opting out.

["PurelyApplied (GitHub)" <gi...@apache.org>]

That was left in the root `build.gradle` because that's where it had effectively been before.

Old style: publication was shoved into a `subprojects {` configuration, and `askpass` was outside that configuration, implicitly applied to the root project that called the `apply from: 'publish.gradle'`.

New style: publication is explicitly requested in the relevant subprojects via their own `apply from: 'publish.gradle'`.  The `askpass` logic which had been applied at root is now explicitly owned by the root's `build.gradle`.

To my eye, that logic is just a sanity check that gets run once the graph is ready.  That seems like a thing to be owned by root.

[ Full content available at: https://github.com/apache/geode/pull/3038 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] PurelyApplied closed pull request #3038: GEODE-6237: Opt into publication rather than opting out.

["PurelyApplied (GitHub)" <gi...@apache.org>]

[ pull request closed by PurelyApplied ]

[ Full content available at: https://github.com/apache/geode/pull/3038 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] rhoughton-pivot commented on pull request #3038: GEODE-6237: Opt into publication rather than opting out.

["rhoughton-pivot (GitHub)" <gi...@apache.org>]

The `askpass` behavior needs to be in root build.gradle becuase not all projects have access to `publish.gradle`, right?

[ Full content available at: https://github.com/apache/geode/pull/3038 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org