You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/12/23 10:31:20 UTC

[GitHub] [iceberg] aokolnychyi commented on a change in pull request #1971: Build: Add separate CI jobs for javadoc and errorprone/checkstyle

aokolnychyi commented on a change in pull request #1971:
URL: https://github.com/apache/iceberg/pull/1971#discussion_r547889582



##########
File path: .github/workflows/java-ci.yml
##########
@@ -37,11 +37,28 @@ jobs:
         path: ~/.gradle/caches
         key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle') }}
         restore-keys: ${{ runner.os }}-gradle
-    - run: ./gradlew check
+    - run: ./gradlew check -Pquick=true -x javadoc
     - uses: actions/upload-artifact@v2
       if: failure()
       with:
         name: test logs
         path: |
           **/build/testlogs
 
+  extra-checks:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v2
+    - uses: actions/setup-java@v1
+      with:
+        java-version: 8

Review comment:
       Are we going to do these checks with java 8 only?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org