You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kyuubi.apache.org by 林小铂 <li...@163.com> on 2022/01/04 06:41:58 UTC
Disable nightly builds on forks by default
Hi team!
Weeks ago I’ve forked kyuubi repo on Github, after which I keep receiving build failure notifications.
I noticed that currently the master branch are not very stable, so I think it would be great if we skip nightly builds on forked repo,
otherwise new contributors might be confused with these errors.
Thanks.
Best,
Paul Lam
Re: Disable nightly builds on forks by default
Posted by Paul Lam <pa...@gmail.com>.
Hi Kent,
Thanks for your advise! I tried and it works as expected. I’ll create a PR.
Best,
Paul Lam
> 2022年1月11日 16:01，Kent Yao <ya...@apache.org> 写道：
>
> Hi Paul,
>
> Can you try this if-condition check?
>
> https://github.com/apache/incubator-kyuubi/blob/master/.github/workflows/publish-snapshot.yml#L9
>
> BR,
>
> Kent
>
> On 2022/01/04 07:26:25 Paul Lam wrote:
>> Hi Kent,
>>
>> Thanks a lot for your reply!
>>
>> I thought it would be easy to fix at first and was preparing a PR, but after some investigation, I found Github action doesn’t support filters on repo.
>>
>> Github recommends that contributors manually disable action workflows on forks [1].
>>
>> BTW, I think build stability is critical as more contributors get involved, and we may need to prioritize it at some point.
>>
>> [1] https://github.blog/changelog/2020-10-01-ability-to-disable-actions-workflows/
>> [2] https://github.community/t/stop-github-actions-running-on-a-fork/17965/2
>>
>> Best,
>> Paul Lam
>>
>>> 2022年1月4日 14:45，Kent Yao <ya...@apache.org> 写道：
>>>
>>> Hi Paul,
>>>
>>> Sorry for the SPAM.
>>>
>>> Looks good to me, if we can disable the nightly build on forked repos
>>>
>>> Kent
>>>
>>> On 2022/01/04 06:41:58 林小铂 wrote:
>>>> Hi team!
>>>>
>>>> Weeks ago I’ve forked kyuubi repo on Github, after which I keep receiving build failure notifications.
>>>>
>>>> I noticed that currently the master branch are not very stable, so I think it would be great if we skip nightly builds on forked repo,
>>>> otherwise new contributors might be confused with these errors.
>>>> Thanks.
>>>>
>>>> Best,
>>>> Paul Lam
>>>>
>>
>>
Re: Disable nightly builds on forks by default
Posted by Kent Yao <ya...@apache.org>.
Hi Paul,
Can you try this if-condition check?
https://github.com/apache/incubator-kyuubi/blob/master/.github/workflows/publish-snapshot.yml#L9
BR,
Kent
On 2022/01/04 07:26:25 Paul Lam wrote:
> Hi Kent,
>
> Thanks a lot for your reply!
>
> I thought it would be easy to fix at first and was preparing a PR, but after some investigation, I found Github action doesn’t support filters on repo.
>
> Github recommends that contributors manually disable action workflows on forks [1].
>
> BTW, I think build stability is critical as more contributors get involved, and we may need to prioritize it at some point.
>
> [1] https://github.blog/changelog/2020-10-01-ability-to-disable-actions-workflows/
> [2] https://github.community/t/stop-github-actions-running-on-a-fork/17965/2
>
> Best,
> Paul Lam
>
> > 2022年1月4日 14:45，Kent Yao <ya...@apache.org> 写道：
> >
> > Hi Paul,
> >
> > Sorry for the SPAM.
> >
> > Looks good to me, if we can disable the nightly build on forked repos
> >
> > Kent
> >
> > On 2022/01/04 06:41:58 林小铂 wrote:
> >> Hi team!
> >>
> >> Weeks ago I’ve forked kyuubi repo on Github, after which I keep receiving build failure notifications.
> >>
> >> I noticed that currently the master branch are not very stable, so I think it would be great if we skip nightly builds on forked repo,
> >> otherwise new contributors might be confused with these errors.
> >> Thanks.
> >>
> >> Best,
> >> Paul Lam
> >>
>
>
Re: Disable nightly builds on forks by default
Posted by Paul Lam <pa...@gmail.com>.
Hi Kent,
Thanks a lot for your reply!
I thought it would be easy to fix at first and was preparing a PR, but after some investigation, I found Github action doesn’t support filters on repo.
Github recommends that contributors manually disable action workflows on forks [1].
BTW, I think build stability is critical as more contributors get involved, and we may need to prioritize it at some point.
[1] https://github.blog/changelog/2020-10-01-ability-to-disable-actions-workflows/
[2] https://github.community/t/stop-github-actions-running-on-a-fork/17965/2
Best,
Paul Lam
> 2022年1月4日 14:45，Kent Yao <ya...@apache.org> 写道：
>
> Hi Paul,
>
> Sorry for the SPAM.
>
> Looks good to me, if we can disable the nightly build on forked repos
>
> Kent
>
> On 2022/01/04 06:41:58 林小铂 wrote:
>> Hi team!
>>
>> Weeks ago I’ve forked kyuubi repo on Github, after which I keep receiving build failure notifications.
>>
>> I noticed that currently the master branch are not very stable, so I think it would be great if we skip nightly builds on forked repo,
>> otherwise new contributors might be confused with these errors.
>> Thanks.
>>
>> Best,
>> Paul Lam
>>
Re: Disable nightly builds on forks by default
Posted by Kent Yao <ya...@apache.org>.
Hi Paul,
Sorry for the SPAM.
Looks good to me, if we can disable the nightly build on forked repos
Kent
On 2022/01/04 06:41:58 林小铂 wrote:
> Hi team!
>
> Weeks ago I’ve forked kyuubi repo on Github, after which I keep receiving build failure notifications.
>
> I noticed that currently the master branch are not very stable, so I think it would be great if we skip nightly builds on forked repo,
> otherwise new contributors might be confused with these errors.
> Thanks.
>
> Best,
> Paul Lam
>