[GitHub] [superset] trepmag commented on a change in pull request #14120: fix: do not render favorite favStars and filters for anonymous user

[GitBox <gi...@apache.org>]

trepmag commented on a change in pull request #14120:
URL: https://github.com/apache/superset/pull/14120#discussion_r631706969



##########
File path: superset/views/core.py
##########
@@ -1747,6 +1747,8 @@ def favstar(  # pylint: disable=no-self-use
         self, class_name: str, obj_id: int, action: str
     ) -> FlaskResponse:
         """Toggle favorite stars on Slices and Dashboard"""
+        if not g.user.get_id():
+            return json_error_response(f"ERROR: Favstar toggling denied", status=403)

Review comment:
       thank you, resolved this in 07e6e6c + includes your suggestion for favorites filter cast.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org