You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/01 13:54:54 UTC
[GitHub] [airflow] zuku1985 opened a new pull request #7321: [AIRFLOW-XXXX]
Remove duplication in BaseOperator docstring
zuku1985 opened a new pull request #7321: [AIRFLOW-XXXX] Remove duplication in BaseOperator docstring
URL: https://github.com/apache/airflow/pull/7321
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Minor change in BaseOperator docs. I removed duplicated queue parameter.
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb commented on a change in pull request #7321:
[AIRFLOW-XXXX] Remove duplication in BaseOperator docstring
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #7321: [AIRFLOW-XXXX] Remove duplication in BaseOperator docstring
URL: https://github.com/apache/airflow/pull/7321#discussion_r373782834
##########
File path: airflow/models/baseoperator.py
##########
@@ -173,8 +173,6 @@ class derived from this one results in the creation of a task object,
DAGS. Options can be set as string or using the constants defined in
the static class ``airflow.utils.WeightRule``
:type weight_rule: str
- :param queue: specifies which task queue to use
Review comment:
Good spot! But could you please remove the other one? This one matches the position of the queue param
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7321: [AIRFLOW-XXXX] Remove
duplication in BaseOperator docstring
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7321: [AIRFLOW-XXXX] Remove duplication in BaseOperator docstring
URL: https://github.com/apache/airflow/pull/7321#issuecomment-581032700
Thanks @zuku1985 !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7321: [AIRFLOW-XXXX]
Remove duplication in BaseOperator docstring
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7321: [AIRFLOW-XXXX] Remove duplication in BaseOperator docstring
URL: https://github.com/apache/airflow/pull/7321#issuecomment-584171117
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7321?src=pr&el=h1) Report
> Merging [#7321](https://codecov.io/gh/apache/airflow/pull/7321?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/53ba6d607c9a3548a996c0c716d1ffb8da0b291b?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7321?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7321 +/- ##
======================================
Coverage 86.3% 86.3%
======================================
Files 871 871
Lines 40660 40660
======================================
Hits 35091 35091
Misses 5569 5569
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7321?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/7321/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5) | `96.51% <ø> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7321?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7321?src=pr&el=footer). Last update [53ba6d6...2d1e37a](https://codecov.io/gh/apache/airflow/pull/7321?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil merged pull request #7321: [AIRFLOW-XXXX] Remove
duplication in BaseOperator docstring
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #7321: [AIRFLOW-XXXX] Remove duplication in BaseOperator docstring
URL: https://github.com/apache/airflow/pull/7321
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] zuku1985 commented on a change in pull request #7321:
[AIRFLOW-XXXX] Remove duplication in BaseOperator docstring
Posted by GitBox <gi...@apache.org>.
zuku1985 commented on a change in pull request #7321: [AIRFLOW-XXXX] Remove duplication in BaseOperator docstring
URL: https://github.com/apache/airflow/pull/7321#discussion_r377067303
##########
File path: airflow/models/baseoperator.py
##########
@@ -173,8 +173,6 @@ class derived from this one results in the creation of a task object,
DAGS. Options can be set as string or using the constants defined in
the static class ``airflow.utils.WeightRule``
:type weight_rule: str
- :param queue: specifies which task queue to use
Review comment:
@ashb I moved the one I left to the proper position. It was more descriptive to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services