You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/12/01 19:23:06 UTC
[GitHub] [helix] pkuwm opened a new pull request #1570: Send partitions list instead of string to custom client Rest API
pkuwm opened a new pull request #1570:
URL: https://github.com/apache/helix/pull/1570
### Issues
- [ ] My PR addresses the following Helix issues and references them in the PR description:
Resolves #1569
### Description
- [ ] Here are some details about my PR, including screenshots of any UI changes:
CustomRestClientImpl serializes the partitions list to a string before sending the payloads to the custom client health check Rest API. The custom client is expecting a list of partitions, but received a string. So the custom client returns an error 400. But actually the partitions are healthy. This is caused by the serialization/deserialization inconsistency between helix rest and custom client rest.
```
curl -X POST http://localhost:11933/partitionHealthStatus -d '{"partitions":["p1"]}'
```
works but Helix will actually send below that doesn't work.
```
curl -X POST http://localhost:11933/partitionHealthStatus -d '{"partitions":"[\"p1\"]"}'
```
### Tests
- [ ] The following tests are written for this issue:
(List the names of added unit/integration tests)
- [ ] The following is the result of the "mvn test" command on the appropriate module:
(Before CI test pass, please copy & paste the result of "mvn test")
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] pkuwm commented on pull request #1570: Send partitions list instead of string to custom client Rest API
Posted by GitBox <gi...@apache.org>.
pkuwm commented on pull request #1570:
URL: https://github.com/apache/helix/pull/1570#issuecomment-736877957
> Code looks good for me. Do we have tests to verify it?
We don’t have a specific test to just test the type of partitions in the payload. It’d be a bit complicated to specifically test the part as it’ll need a http server running and some context to verify the payload the custom client receives. Mocking doesn’t work for testing this specific part.
I’ve manually tested it by connecting it to SN. And print out the payloads. It is what we want: list of partitions, not a string. I think this change it fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] pkuwm commented on pull request #1570: Send partitions list instead of string to custom client Rest API
Posted by GitBox <gi...@apache.org>.
pkuwm commented on pull request #1570:
URL: https://github.com/apache/helix/pull/1570#issuecomment-736889897
This PR is ready to be merged, approved by @dasahcc
Problem:
CustomRestClientImpl serializes the partitions list to a string before sending the payloads to the custom client health check Rest API. The custom client is expecting a list of partitions, but received a string. So the custom client returns an error 400. But actually the partitions are healthy. This is caused by the serialization/deserialization inconsistency between helix rest and custom client rest.
Solution:
Keep the partitions list in the payload without serializing it to a string when sending post request. So the custom client will get the list of partitions after deserializing the payloads.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] pkuwm merged pull request #1570: Send partitions list instead of string to custom client Rest API
Posted by GitBox <gi...@apache.org>.
pkuwm merged pull request #1570:
URL: https://github.com/apache/helix/pull/1570
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org