You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2013/05/06 15:00:17 UTC
[jira] [Commented] (BEANUTILS-439) Save Logger in static field in
MethodUtils instead of requesting it on every method invocation
[ https://issues.apache.org/jira/browse/BEANUTILS-439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13649720#comment-13649720 ]
Sebb commented on BEANUTILS-439:
--------------------------------
Re: 1. Found a reference to static logging:
https://issues.apache.org/jira/browse/CHAIN-29
which references
http://wiki.apache.org/commons/Logging/StaticLog
Re: 3. MethodUtils does not make much use of logging (compared with some other BeanUtils classes) so dropping logging would probably not have much affect. Particularly since the logging code looks to be associated with Java versions prior to 1.4, and BeanUtils now requires at least 1.5. Looks to me as though the logging in MethodUtils can be dropped entirely. This would simplify the class, and the field loggedAccessibleWarning can be dropped (it's not currently thread-safe anyway).
> Save Logger in static field in MethodUtils instead of requesting it on every method invocation
> ----------------------------------------------------------------------------------------------
>
> Key: BEANUTILS-439
> URL: https://issues.apache.org/jira/browse/BEANUTILS-439
> Project: Commons BeanUtils
> Issue Type: Improvement
> Components: Bean / Property Utils
> Affects Versions: 1.8.3
> Reporter: Benedikt Ritter
> Assignee: Benedikt Ritter
> Labels: logging, performance
> Fix For: 1.8.4
>
>
> It was proposed on the ML to create a static field reference to the Logger in MethodUtils, because requesting it on every method invocation leads to bad performance (see http://markmail.org/message/ysurofedfoikdguu).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira