You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Mayuresh Gharat <gh...@gmail.com> on 2014/10/01 08:21:51 UTC
Re: Review Request 25136: Patch for KAFKA-1610
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25136/
-----------------------------------------------------------
(Updated Oct. 1, 2014, 6:21 a.m.)
Review request for kafka.
Bugs: KAFKA-1610
https://issues.apache.org/jira/browse/KAFKA-1610
Repository: kafka
Description (updated)
-------
Reverting the changes and adding comments to make the usage of mapValues more clear
Formatted the comments
Removed comments and changed variable names as per the reviews
Removed comments and changed variable names as per the reviews
Diffs (updated)
-----
core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala 691d69a49a240f38883d2025afaec26fd61281b5
core/src/main/scala/kafka/controller/KafkaController.scala 8ab4a1b8072c9dd187a9a6e94138b725d1f1b153
core/src/main/scala/kafka/server/DelayedFetch.scala e0f14e25af03e6d4344386dcabc1457ee784d345
core/src/main/scala/kafka/server/DelayedProduce.scala 9481508fc2d6140b36829840c337e557f3d090da
core/src/main/scala/kafka/server/KafkaApis.scala c584b559416b3ee4bcbec5966be4891e0a03eefb
core/src/main/scala/kafka/server/KafkaServer.scala 3e9e91f2b456bbdeb3055d571e18ffea8675b4bf
core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala ba6ddd7a909df79a0f7d45e8b4a2af94ea0fceb6
core/src/test/scala/unit/kafka/server/LeaderElectionTest.scala c2ba07c5fdbaf0e65ca033b2e4d88f45a8a15b2e
Diff: https://reviews.apache.org/r/25136/diff/
Testing
-------
Ran the unit tests and everything passed and the build succeeeded
Thanks,
Mayuresh Gharat
Re: Review Request 25136: Patch for KAFKA-1610
Posted by Mayuresh Gharat <gh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25136/
-----------------------------------------------------------
(Updated Oct. 2, 2014, 7:09 p.m.)
Review request for kafka.
Bugs: KAFKA-1610
https://issues.apache.org/jira/browse/KAFKA-1610
Repository: kafka
Description (updated)
-------
Reverting the changes and adding comments to make the usage of mapValues more clear
Formatted the comments
Removed comments and changed variable names as per the reviews
Removed comments and changed variable names as per the reviews
Removed the comments and made the code self explanatory regarding usage of mapValues
Correction
Diffs (updated)
-----
core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala 691d69a49a240f38883d2025afaec26fd61281b5
core/src/main/scala/kafka/controller/KafkaController.scala 8ab4a1b8072c9dd187a9a6e94138b725d1f1b153
core/src/main/scala/kafka/server/DelayedFetch.scala e0f14e25af03e6d4344386dcabc1457ee784d345
core/src/main/scala/kafka/server/DelayedProduce.scala 9481508fc2d6140b36829840c337e557f3d090da
core/src/main/scala/kafka/server/KafkaApis.scala c584b559416b3ee4bcbec5966be4891e0a03eefb
core/src/main/scala/kafka/server/KafkaServer.scala 3e9e91f2b456bbdeb3055d571e18ffea8675b4bf
core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala ba6ddd7a909df79a0f7d45e8b4a2af94ea0fceb6
core/src/test/scala/unit/kafka/server/LeaderElectionTest.scala c2ba07c5fdbaf0e65ca033b2e4d88f45a8a15b2e
Diff: https://reviews.apache.org/r/25136/diff/
Testing
-------
Ran the unit tests and everything passed and the build succeeeded
Thanks,
Mayuresh Gharat
Re: Review Request 25136: Patch for KAFKA-1610
Posted by Mayuresh Gharat <gh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25136/
-----------------------------------------------------------
(Updated Oct. 2, 2014, 7:07 p.m.)
Review request for kafka.
Bugs: KAFKA-1610
https://issues.apache.org/jira/browse/KAFKA-1610
Repository: kafka
Description (updated)
-------
Reverting the changes and adding comments to make the usage of mapValues more clear
Formatted the comments
Removed comments and changed variable names as per the reviews
Removed comments and changed variable names as per the reviews
Removed the comments and made the code self explanatory regarding usage of mapValues
Diffs (updated)
-----
core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala 691d69a49a240f38883d2025afaec26fd61281b5
core/src/main/scala/kafka/controller/KafkaController.scala 8ab4a1b8072c9dd187a9a6e94138b725d1f1b153
core/src/main/scala/kafka/server/DelayedFetch.scala e0f14e25af03e6d4344386dcabc1457ee784d345
core/src/main/scala/kafka/server/DelayedProduce.scala 9481508fc2d6140b36829840c337e557f3d090da
core/src/main/scala/kafka/server/KafkaApis.scala c584b559416b3ee4bcbec5966be4891e0a03eefb
core/src/main/scala/kafka/server/KafkaServer.scala 3e9e91f2b456bbdeb3055d571e18ffea8675b4bf
core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala ba6ddd7a909df79a0f7d45e8b4a2af94ea0fceb6
core/src/test/scala/unit/kafka/server/LeaderElectionTest.scala c2ba07c5fdbaf0e65ca033b2e4d88f45a8a15b2e
Diff: https://reviews.apache.org/r/25136/diff/
Testing
-------
Ran the unit tests and everything passed and the build succeeeded
Thanks,
Mayuresh Gharat