[GitHub] [tvm] mei-ye opened a new issue #10857: Another stack overflow due to recursive call in device_planner.cc

[GitBox <gi...@apache.org>]

mei-ye opened a new issue #10857:
URL: https://github.com/apache/tvm/issues/10857


   @mbs-octoml 
   @masahi 
   
   Another stack overflow due to recursive calls in device_planner.cc is found:
   class DeviceCapturer : public ExprMutator {
   ....
     Expr VisitExpr_(const CallNode* call_node) final {
        // Recursive calls here.
        args.push_back(VisitChild(/*lexical_virtual_device=*/call_virtual_device,
   
     }
   ...  
   }
   
   MixedModeExprMutator can't be used here since it has "final" declaration for VisitExpr.
   What's your suggestion?  Thanks!
    


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi commented on issue #10857: Another stack overflow due to recursive call in device_planner.cc

[GitBox <gi...@apache.org>]

masahi commented on issue #10857:
URL: https://github.com/apache/tvm/issues/10857#issuecomment-1085507647


   I think we can override `Rewrite_` methods in `DeviceCapturer` as documented here:
   https://github.com/apache/tvm/blob/1df1580ef0d0543b5c0a4bad95db8133bb4afc89/include/tvm/relay/expr_functor.h#L292-L302
   
   `MixedModeMutator` is used in a lot of places, you can have a look at how they are implemented.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org